Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dropbox/dropbox_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def request_json_string_with_retry(
"ExpiredCredentials status_code=%s: Refreshing and Retrying",
e.status_code,
)
self.refresh_access_token()
self.refresh_access_token(scope=self._scope)
has_refreshed = True
else:
raise
Expand Down
24 changes: 24 additions & 0 deletions test/unit/test_dropbox_unit.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

# Tests OAuth Flow
from dropbox import DropboxOAuth2Flow, session, Dropbox, create_session
from dropbox import auth
from dropbox.base import DropboxBase
from dropbox.common import PathRoot
from dropbox.content_hash import content_hash
Expand Down Expand Up @@ -787,6 +788,29 @@ def test_refresh_raises_after_exhausting_retries(self, server_error_session_inst
# Initial attempt + 2 retries.
assert server_error_session_instance.post.call_count == 3

def test_refresh_on_expired_access_token_uses_client_scope(self, session_instance, mocker):
# A 401 expired_access_token triggers a refresh, which must request the
# scope the client was configured with, like check_and_refresh_access_token.
dbx = Dropbox(
oauth2_access_token=ACCESS_TOKEN,
oauth2_refresh_token=REFRESH_TOKEN,
oauth2_access_token_expiration=EXPIRATION,
app_key=APP_KEY,
app_secret=APP_SECRET,
scope=SCOPE_LIST,
session=session_instance,
)
expired = AuthError("request-id", auth.AuthError.expired_access_token)
request = mocker.patch.object(dbx, "request_json_string", side_effect=[expired, "{}"])

result = dbx.request_json_string_with_retry("api", "test", "rpc", "{}", USER_AUTH, None)

assert result == "{}"
assert request.call_count == 2
session_instance.post.assert_called_once()
token_body = session_instance.post.call_args.kwargs["data"]
assert token_body.get("scope") == " ".join(SCOPE_LIST)


class TestAutoContentHash:
def _fake_file_metadata(self, size, file_content_hash):
Expand Down
Loading