Repository navigation
Encode Nexus arguments with the portable Avro codec - #113
Merged
Merged
Conversation
This was referenced Oct 11, 2026
rmcdaniel
marked this pull request as ready for review
October 11, 2026 09:19
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Part of #112. Nexus arguments now use the SDK's existing fixed-schema Avro serializer and matching codec field. This corrects the plain JSON argument list that reached the published PHP service as missing workflow input.
Focused tests decode the actual outgoing bytes for empty, scalar, nested and binary arguments, reject JSON codecs, check the recorded request and preserve the existing deterministic idempotency input. Eleven focused client/replay/wire tests pass in a bounded Python 3.12 container.
Oversized Nexus arguments now use runtime payload upload without changing the recorded Avro request. Inline arguments stay serialized strings. Oversized payloads beyond the runtime limit are refused before upload or admission. The minimal Avro corpus fixture reproduces the original lost argument value.
Normal source, package, Python 3.10/3.11/3.12, integration, docs, corpus and target-branch checks pass at 4fd2468. Published consumer qualification follows the release and Server transport fix durable-workflow/server#396. Issue #112 stays open through that verification. Target-namespace addressing is separately tracked in #111. Terminal linked service/caller convergence is durable-workflow/workflow#753.