Repository navigation
Conversation
Replace with shields.io as github's badge would show up as "pr: passing" which might be confusing. Instead sheilds badge to get "CI: passing" Fixes: eclipse-basyx#656
zrgt
left a comment
There was a problem hiding this comment.
Bug (one):
- Badge counts PR runs as well as pushes. The URL filters only on
branch=main. For a PR run, GitHub's branch filter matches the PR's source branch, so any PR opened from a branch namedmaincounts, which is common for fork PRs. A failing fork PR frommainwould turn the badge red even when main itself is fine. This is already happening: in the live API, the newestpr.ymlrun with branchmainis a pull_request run (2026-10-02 12:05), not the push at 11:59. That goes against issue #656, which wants the badge to show the last push to main.- Fix: add
&event=push, givingpr.yml?branch=main&event=push&label=CI.
- Fix: add
Minor:
- Link doesn't match the image. The image shows main only, but clicking it opens the full
pr.ymlrun list for every branch. Point the link toactions/workflows/pr.yml?query=branch%3Amain+event%3Apush. - shields.io isn't needed. The PR switches to shields.io only because GitHub's own badge reads "pr: passing". That text comes from the
name: prline inpr.yml. Renaming it toname: CIgives the GitHub badge the right label and avoids shields.io's caching delay and rate-limit outages. - "CI" label is too broad. The badge covers only
pr.yml. The separatemain.ymlworkflow (ARM Docker build and smoke tests on PRs into main) isn't included, so the badge can say "CI: passing" while the release build is broken. Either use a narrower label like "tests" or add a second badge.
|
Thank you for the feedback.
But I am not sure what would better describe |
|
Thanks — 1. and 2. look good. On 3.: yes, <a href="https://github.com/eclipse-basyx/basyx-python-sdk/actions/workflows/pr.yml?query=branch%3Amain+event%3Apush"><img src="https://github.com/eclipse-basyx/basyx-python-sdk/actions/workflows/pr.yml/badge.svg?branch=main&event=push" alt="CI"></a>Both On 4.: let's drop the second-badge option — a badge for So: one badge, For the |
Update from old
ci.ymltopr.ymlto get badge to function again.Also replaced with shields.io as github's badge would show up as "pr: passing" which might be confusing.
Instead shields badge to get "CI: passing".
Fixes: #656