Repository navigation
ui: a composition detail panel's rows offer their record's actions, also on the master's preview (#8289) - #8290
Merged
Conversation
…lso on the master's preview (#8289) detailPanel gains rowActions(row) and runRowAction(action, row), the pair relatedPanel has since #8118: the child entity's actions its status guards and roles allow. The panel's row menu lists them first, before Preview, Edit and Delete; on the master's preview the menu is shown for a row with actions and offers them and Preview only - Edit and Delete stay withheld there. A composition child has no list and its Preview dialog shows no actions, so before this its declared actions were unreachable without typing its route. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A composition child is listed on its master's page in a detail panel, and its declared actions could not be reached from there:
A composition child has no list either, so its actions (#8116, #8119) showed only on its own route, which nothing links to.
Change
detailPanelgainsrowActions(row)andrunRowAction(action, row), the pairrelatedPanelhas had since ui: a related: register's rows offer their record's actions - a row menu beside Open, by the source's status guards #8118. They return the child entity's actions that the row's status guards and the user's roles allow.relatedPanelkeeps its ownrowActions: a cross-project register still asks for nothing.form-view.html.template):x-showfollows the row cell's.onActionDone.Verified
Run locally, in a worktree of
masterat83001098f1:HarmoniaRecordActionsITaDetailPanelRowOffersItsChildsActionsByStatus: the shippeddetailPanel.rowActionsagainst the shipped store, plus the template's preview rulesIntentCallActionSampleITmvn -T 1C formatter:validateIntentCallActionSampleITextends its model with aWatchercomposition child ofTicketand aMuteaction:[Mute, Preview], and the MUTED watcher's row has no menu;[Mute, Preview, Edit, Delete];Not run:
Fixes #8289
🤖 Generated with Claude Code