Repository navigation
build: DatabaseFacadeIT's binary column is BYTEA on PostgreSQL, which has no VARBINARY (#8143 follow-up) - #8292
Merged
Merged
Conversation
… has no VARBINARY (#8143 follow-up) The BinaryTest added by #8281 created a VARBINARY(100) column, which PostgreSQL rejects with 'type "varbinary" does not exist', so all four of its tests errored on the PostgreSQL legs of master. On PostgreSQL the column is now BYTEA, its variable-length binary type (it takes no length). The dialect still renders VARBINARY verbatim; that is #8291. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
#8281 (#8143) added
DatabaseFacadeIT$BinaryTest, which creates aVARBINARY(100)column. PostgreSQL has no such type:All four of its tests errored on the PostgreSQL
slowleg of master (run 40663727492, job 122732864039). The H2 leg passed.Change
On PostgreSQL the column is now
BYTEA(PostgreSQL's variable-length binary type, which takes no length). Other databases keepVARBINARY(100). The test is the only thing changed here. The dialect still rendersVARBINARYverbatim on PostgreSQL, which is filed as #8291.Verified
DatabaseFacadeITagainst a local PostgreSQL 16 (DefaultDB and SystemDB both on it): 47 run, 0 failures, 0 errors, 2 skipped.pg_stat_database.tup_insertedconfirmed the run wrote to PostgreSQL.DatabaseFacadeITon H2: 47 run, 0 failures, 0 errors, 2 skipped.formatter:validateontests/tests-integrationswith the cache wiped.Not part of this PR (the other two red jobs on master)
integration-tests-h2 (slow), run 40663690485:IntentResilienceSampleITtimed out. The "notify" tenant endedProvisionedwith noFailureMessage, and the log shows no send failure for itsnotifyOwnerstep. The same commit passed on the PostgreSQLslowleg, earlier master runs passed, and it passes locally. I tested one cause (mail config leaking from a tag-filtered class's static initializer in the shared fork) and the repro disproved it. The cause is still open.integration-tests-postgresql (api-2), same run: "The hosted runner lost communication with the server" partway through a cleanup. Infrastructure.🤖 Generated with Claude Code