Repository navigation
#8115 - a generated number field keeps a zero typed after the decimal point - #8293
Merged
Merged
Conversation
Signed-off-by: StanZGenchev <stan.genchev@codbex.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since the generated UI moved to Harmonia, a number field bound with
x-model.numbercould lose a zero typed after the decimal point. Alpine writes the model back into the focused input whenever the model changes, so a field reading 1.0 with a model of 1 was rewritten to 1 and the next digit made 15, which is what got saved (#8115, codbex/harmonia#149). Harmonia 3.6.2 fixes it inside the x-h-input-number directive, and this PR bumpsharmonia.versionto 3.6.2.The 3.6.2 reference also marks data-orientation on
x-h-separatoras required, and the form builder's "line" control was the one separator without it. It now renders the reference's shape.NumberInputHarmoniaITcovers the fix in a real browser.Breaking changes
None.
What issues does this PR fix or reference?
Fixes #8115