Repository navigation
Conversation
…ose (eclipse-dirigible#8225) A failed startup left the container Up with no HTTP listener: SpringApplication.run rethrows, main exits, but the two non-daemon reader threads in ProcessRunnable (and the launcher thread) kept the JVM alive, so no Docker restart policy fired. - ProcessRunnable now spawns its stdout/stderr reader threads as named daemon threads and exposes destroy() to stop the process. - TerminalWebsocketConfig starts ttyd from a @PostConstruct lifecycle hook on a daemon launcher thread (replacing the static-initializer start that ran before context refresh) and destroys it from @PreDestroy, so ttyd no longer outlives a closed context. With the reader threads daemon, a refresh failure lets the JVM exit non-zero as expected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed startup left the container Up with no HTTP listener: SpringApplication.run rethrows and main exits, but the two non-daemon reader threads in ProcessRunnable (and the launcher thread) kept the JVM alive, so no Docker restart policy fired.
Changes (components/ide/ide-terminal):
With the reader threads daemon, a refresh failure lets the JVM exit non-zero as expected.
Verified: ide-terminal unit suite green (new ProcessRunnableTest + existing); formatter:validate green with the cache wiped. The Docker-level exit/restart behavior was reproduced by the reporter and is not covered by the IT harness.
Fixes #8225
🤖 Generated with Claude Code