Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Pending destruction can be abandoned during JVM shutdown, and cross-platform process cleanup needs verification.
Review effort: Balanced
Findings: 1
What changed in this PR
Moves terminal process destruction off the calling thread to reduce UI freezes when closing tabs or the workbench.
Changes:
- Adds a daemon-thread helper for process destruction.
- Schedules destruction before stream cleanup on non-Windows platforms and afterward on Windows.
| File | Description |
|---|---|
| terminal/bundles/org.eclipse.terminal.connector.process/src/org/eclipse/terminal/connector/process/ProcessConnector.java | Moves process destruction into a background thread. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| private static void destroyInBackground(Process process) { | ||
| // Spawner.destroy() waits up to a second for a shell that ignores SIGTERM | ||
| Thread thread = new Thread(process::destroy, "Terminal Process Destroy Thread"); //$NON-NLS-1$ | ||
| thread.setDaemon(true); |
Contributor
Spawner.destroy() sends SIGTERM and then waits up to a second before killing the process. An interactive shell ignores SIGTERM, so closing a terminal tab blocked the UI thread for a full second, and closing the workbench with several terminals open froze it for that long per tab. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
terminal-destroy-process-async
branch
from
October 8, 2026 12:14
377e835 to
541d90b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a terminal tab, or the workbench with terminals open, froze the UI because ProcessConnector called the CDT Spawner's destroy() on the UI thread. That method sends SIGTERM and waits up to a second before sending SIGKILL, and an interactive shell ignores SIGTERM, so every open terminal added a full second of freeze on shutdown. The process is now destroyed in a background thread, keeping the existing platform-specific order relative to closing the streams. Closing the streams still hangs up the PTY, so the shell exits promptly even when the JVM is shutting down.