Repository navigation
Conversation
|
Was Clang 2.9 really the first version which enabled this? |
Author
As a wrote "Note that I picked clang 2.9 as the lower bound, as that was the minimum version I was reasonably able to test against.", but let me do some further digging and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not able to open an issue, as that is currently restricted to contributors, of which I am not one. Hence, I'm just opening a PR with a fix, which I understand is not ideal.
We noticed a regression where empty initializers for aggregates are no longer accepted when emulating clang versions before clang 17. For example, the following fails with EDG 7.0:
This seems to be due to the changes made as part of EDGcpfe/29042. This PR restores the behavior for empty aggregate initializers. Note that I picked clang 2.9 as the lower bound, as that was the minimum version I was reasonably able to test against.