Repository navigation
Conversation
daveedvdv-nvidia
left a comment
daveedvdv-nvidia
left a comment
There was a problem hiding this comment.
Minor test organization request.
|
This looks generally okay for me. I'd just split the tests in a positive and negative test file. (Or: Single test file with -DPOS and/or -DNEG options.) |
Contributor
Author
The tests are now in two files; one for positive and one for negative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call-depth cost is now charged after the arguments are evaluated. Previously in an evaluation like
add(1, f(n-1))the call toaddwas charged whilef(n-1)was still being evaluated so each level of recursion was double counted.Closes: #178