Skip to content

Add replay to the edg-docker-test tool [] - #246

Open
wchilders-nvidia wants to merge 1 commit into
mainfrom
add-replay-to-edg-docker-test
Open

wchilders-nvidia wants to merge 1 commit into
mainfrom
add-replay-to-edg-docker-test

Conversation

@wchilders-nvidia

Copy link
Copy Markdown
Collaborator

This exposes the --replay flag to edg-docker-test to allow users to update recordings more easily when using edg-docker-test.

For instance, if you run:

edg-docker-test --posture=extensive
edg-test-run-diff

and conclude all of the changes are good, you can then run:

edg-docker-test --posture=extensive --replay unexpected -W

to rerun and update only the tests with changes, after this change.

Reviewed internally by: @daveedvdv-nvidia

@mborland mborland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In replay mode, edgy ignores --run-timestamp per it's help txt so the replay output goes to tests/runs//replays/N. edg-docker-test still makes a new timestamp and points AcknowlEDG at it. Locally I ran:

exec edgy --run-timestamp=2026.10.08-13.17.06 --config="edg_x86_64_cp,edg_x86_64" --replay=regress                                                                                                                                                                                                               
  exec edgy-review --root='/edg/workspace/tests/runs/2026.10.08-13.17.06' 

edgy-review prints Path does not exist: … and exits 1, and run_acknowledg then calls sys.exit(1).

The fix is a one liner which I have attached as a patch file. It simply skips trying to open the non-existent directory.

replay-acknowledg.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants