Repository navigation
Add replay to the edg-docker-test tool [] - #246
Open
wchilders-nvidia wants to merge 1 commit into
Open
wchilders-nvidia wants to merge 1 commit into
wchilders-nvidia wants to merge 1 commit into
Conversation
mborland
reviewed
Oct 8, 2026
mborland
left a comment
Contributor
There was a problem hiding this comment.
In replay mode, edgy ignores --run-timestamp per it's help txt so the replay output goes to tests/runs//replays/N. edg-docker-test still makes a new timestamp and points AcknowlEDG at it. Locally I ran:
exec edgy --run-timestamp=2026.10.08-13.17.06 --config="edg_x86_64_cp,edg_x86_64" --replay=regress
exec edgy-review --root='/edg/workspace/tests/runs/2026.10.08-13.17.06'
edgy-review prints Path does not exist: … and exits 1, and run_acknowledg then calls sys.exit(1).
The fix is a one liner which I have attached as a patch file. It simply skips trying to open the non-existent directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes the
--replayflag toedg-docker-testto allow users to update recordings more easily when usingedg-docker-test.For instance, if you run:
and conclude all of the changes are good, you can then run:
to rerun and update only the tests with changes, after this change.
Reviewed internally by: @daveedvdv-nvidia