Repository navigation
Implement fix for "if constexpr" incorrectly handling non-brace statements [GH #229] - #247
Open
wchilders-nvidia wants to merge 2 commits into
Open
wchilders-nvidia wants to merge 2 commits into
wchilders-nvidia wants to merge 2 commits into
Conversation
mborland
reviewed
Oct 8, 2026
mborland
left a comment
mborland
left a comment
Contributor
There was a problem hiding this comment.
With MSVC __try ... __finally in a discarded branch now fails because the __finally is not consumed. The fix is a one-liner and there is an included test for this case in the attached patch file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes GH #229 and also includes a fix for some changes entry formatting issues.
Reviewed internally by: @daveedvdv-nvidia