Repository navigation
Add temporary environment review reduction and prepare v0.9.0 - #72
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42893949e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abd375c8e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02ae09df71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cf4497a10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds Reduce environment checks, off by default. From a pending environment review, the local owner can acknowledge the unverified target and reduce environment-only review for one exact connection in the current session for 15 minutes. Active grants show the session/connection ID, countdown and Stop; inactive controls do not resize an idle terminal. Grants stay in memory, never renew on reads or duplicate clicks, and cannot be created or extended through agent IPC/MCP. Agents can read only their own state.
The first version fails closed outside a documented set of literal POSIX query commands. Unknown executables, launchers, file-changing commands with unchecked remote protected targets, wrappers, leading assignments, shell expansion/history/compound syntax and nonliteral printf conversions keep review. Even supported queries obey custom deny/confirm rules first. Existing category allowances remain separate, and pending cards are never automatically approved. Privacy, participation, Observe/Co-pilot, control leases, OS authentication and input recovery keep their requirements. Final targets, aliases/functions and executable identity remain unverified; nested host changes may be undetectable.
Every queued request binds to its admission context and original grant, including requests admitted without a grant. A later grant cannot authorize an older request. Expiry, stop, disconnect, sharing/context changes or human takeover revoke grants; natural lease expiry preserves the grant but prevents writes. Immediate execution, grace execution and owner co-sign recheck context, permissions, lease and monotonic expiry immediately before PTY input, including after owner-event/audit delivery. Cancelled input requires explicit recovery, and running processes are not killed.
Prepares v0.9.0 using the existing preview release conventions, version/lockfile tooling, bilingual UI and user documentation. The five automated review findings have dedicated coverage: pathname expansion, history expansion, coprocess syntax, unchecked protected targets and resource-control launchers. The supported-query design keeps arbitrary new launchers under review by default; printf variable writes/arithmetic formats also remain reviewed.
Validation: 315 Rust tests (one existing ignored), 23 newly added grant/policy/transport/queue regressions, common UI tests, desktop/web/site builds, film type check, 85 grid/cursor comparisons, 984 checkpoint comparisons, app-lifetime isolation, 10 collaboration + 5 environment-control production Linux Chromium UI/PTY/MCP scenarios, 15 retained-input/header/connection scenarios, owner contract/boundary checks, version/hygiene/link checks and 81 release-tooling tests. See
docs/release-0.9.0-validation.md. Required CI and review must complete on final head before merge.Limits: local native compilation lacks GTK development libraries; native builds are validated in CI. macOS/Windows interactive behavior and installed-app upgrades are untested locally. Strict Clippy independently reproduces the same five findings on upstream base
744fa22and the candidate; non-strict Clippy succeeds. Full-base formatting drift is reproduced, and both new Rust files plus the new policy guard functions pass rustfmt. No installed user app, running user terminal, live user grant, credentials, signing trust, protection rules or quotas were changed. Tagged-release signing, exact uploaded-asset hashes/runtime and site publication are verified separately before delivery.