Repository navigation
docs(readme): refresh outdated examples and versions - #169
SatvikMishra08 wants to merge 3 commits into
Conversation
|
Thanks for working on this! This branch is based on 97f764a, and #170-#174 have been merged into master since then, so some of the refreshed sections are already out of date. Also, several example outputs look like they were re-indented by hand instead of regenerated, so they don't match what the tool prints now. Could you rebase onto current master and regenerate each example by running Details below (line numbers refer to README.md in this PR). Out of date after rebase
Examples that don't match real output
Examples that fail when copied
"Tested on" wording (L20, L411)CI has a single NitThis repo uses |
Address review on ekalinin#169: rebase onto current master, regenerate README examples with ./gh-md-toc, simplify the tests blurb, add Actions contents: write, and note the published 0.10.0 image limits. Fixes ekalinin#165.
d11a237 to
f60a7e8
Compare
|
Thanks @ekalinin — addressed your review on a rebase of current
Happy to tweak further if anything still looks off. |
The tool writes Added-by timestamps with default `date`, not %F_%H%M%S (that format is only for backup filenames).
ekalinin
left a comment
There was a problem hiding this comment.
Thanks for refreshing the examples! A few things I'd fix before merging:
- The sitemap.js part of the Combo example (
README.md:272) is broken. Its H1 onblob/masternow has badges, so the first entry gets badge HTML as the link text and a URL likeREADME.mdhttps://camo.... Pinning it to6bc3eb12, like the tests do, should fix it. - The Docker example (
README.md:488) runs 0.10.0 on enviriusblob/master, which is the #166 case, so it prints page HTML. Pinning won't help here, because 0.10.0 prints the same<button ...>entry on the pinnedf939d3bURL too. The nodeenv wiki URL fromsite/index.htmlworks with 0.10.0. - "currently 17 tests" (
README.md:442) is already out of date:masterhas 22 after #177. I'd just drop the number. - In Remote files (
README.md:143), the text talks about a README without a TOC, but the example runs onblob/master, which already has one, so* [Table of Contents]shows up in the output. The pinnedf939d3bURL gives output that matches the text. - Running
--inserton the README itself breaks it (README.md:297-298,331). Thesedrange isn't anchored, so it picks up the<!--ts-->/<!--te-->markers inside the code blocks, and the TOC lands in the examples.
|
Hi @ekalinin, just checking in: the rebase on current |
Address review on ekalinin#169: - pin the sitemap.js part of the Combo example to 6bc3eb12 - point Remote files at the pinned envirius f939d3b README - use the nodeenv wiki URL for the public Docker 0.10.0 example - drop the test count from the Tests section - only touch the first full-line <!--ts-->/<!--te--> pair in --insert, so markers quoted in code blocks are left alone
|
Thanks @ekalinin! All 5 are addressed in 0cd28f7:
Happy to move the |
ekalinin
left a comment
There was a problem hiding this comment.
Thanks for the update! The examples look good now. A few things before merging:
- The
--insertchange introduces two regressions. The new range stops at the first full-line<!--te-->, so it doesn't really skip code blocks. If a code block with only<!--te-->comes before the real markers, nothing is updated but the tool still prints "TOC was added". If a code block shows the<!--ts-->/<!--te-->pair above the real TOC, the new TOC goes into the example and the real one stays stale. Master updates the real TOC in both cases. The README case already happens on master, so it doesn't need to block this PR. Let's take you up on your offer: please drop thegh-md-tocchange from this PR and open a separatefixPR with--inserttests, one that skips markers inside code fences instead of relying on the first pair. grep -A20in the--insertexample (README.md:319). It prints 20 lines after<!--ts-->, but the shown block ends 13 lines later at<!--te-->, so unless the markers are at the very end of the file, the real output continues past<!--te-->.-A13matches the output shown.docker imagessize (README.md:475). 72MB is the compressed size from Docker Hub.docker imagesshows the uncompressed size, which is larger (the old README showed 147MB for 0.7.0, which is 71MB on Docker Hub).0.10.0note (README.md:481). After merging with master, the README also documents--numbered(#177), which 0.10.0 doesn't support either. Please mention it next to--depth.
Fixes #165.
README-only refresh for outdated examples and version pins:
--indent 3, seetests/tests.bats)<!--ts-->…<!--te-->TOC to match current outputactions/checkout@v7,stefanzweifel/git-auto-commit-action@v70.7.0to0.10.0(matchesgh_toc_version/ Docker Hub)ubuntu-latest)sitemap.s→sitemap.js)No feature changes. One small fix in
gh-md-toc:--insertnow only clears/inserts between the first full-line<!--ts-->/<!--te-->pair, so example markers inside README code blocks are left alone (found while applying review feedback). README headings are unchanged so bats heading assertions stay valid.