Repository navigation
Fix JVM tool bootstrap check with program arguments containing slashes - #4602
Open
RaphaelFakhri wants to merge 2 commits into
Open
RaphaelFakhri wants to merge 2 commits into
RaphaelFakhri wants to merge 2 commits into
Conversation
🤖 GitHub commentsJust comment with:
|
Author
|
The PayaraIT failures came from this change: the Payara main class |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4269.
JvmToolBootstrapChecksplits the wholesun.java.commandvalue on/, including the program arguments. Because of this:java org.example.Main --file /my/path/file.txt, logsUnexpected JVM command line syntax.keytool -list -keystore /tmp/keystore.jks, is not detected as a JVM tool. The agent logs the same warning and instruments the tool.The check now applies the
/split to the main class or module part only, which is the first space-separated token. Commands without arguments behave as before, including the warning for unexpected main class syntax such as/my/app/Main.The tests cover a JVM tool with a path argument, with and without a module prefix, and an application with a path argument, with and without a module prefix.
Checklist