Skip to content

ci: bump secret-service-action to v1.1.0 - #486

Merged
MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0

Conversation

@claude

@claude claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 21:37

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. The bumped action is the one that fetches the release job's GitHub token, so a human should still confirm the new pin before merging.

What was reviewed:

  • The only change is the electron/secret-service-action pin in .github/workflows/release.yml. It's still a full 40-character SHA with a # v1.1.0 comment, which matches how the repo pins its other actions.
  • The step id and the later fromJSON(steps.secret-service.outputs.secrets).GITHUB_TOKEN usage are unchanged, and the job's permissions are unchanged.
  • I couldn't check from this checkout that 23b9042f… is the upstream v1.1.0 tag, or that v1.1.0 still returns the secrets output in the same shape.
Extended reasoning...

The change is a one-line bump of the pinned SHA for electron/secret-service-action in the release workflow. That step gets the GITHUB_TOKEN that semantic-trusted-release uses, and the job runs with id-token: write in the npm-trusted-publisher environment, so this touches credential handling. A CODEOWNERS rule (*) covers every file in the repo, including this one. I couldn't confirm the new SHA against the upstream tag, so I deferred instead of approving.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 21:41
@MarshallOfSound
MarshallOfSound merged commit cc8c40b into main Oct 22, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the bump-secret-service-action-v1.1.0 branch October 22, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants