Repository navigation
ci: bump secret-service-action to v1.1.0 - #486
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
Contributor
Author
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. The bumped action is the one that fetches the release job's GitHub token, so a human should still confirm the new pin before merging.
What was reviewed:
- The only change is the
electron/secret-service-actionpin in.github/workflows/release.yml. It's still a full 40-character SHA with a# v1.1.0comment, which matches how the repo pins its other actions. - The step id and the later
fromJSON(steps.secret-service.outputs.secrets).GITHUB_TOKENusage are unchanged, and the job's permissions are unchanged. - I couldn't check from this checkout that
23b9042f…is the upstream v1.1.0 tag, or that v1.1.0 still returns thesecretsoutput in the same shape.
Extended reasoning...
The change is a one-line bump of the pinned SHA for electron/secret-service-action in the release workflow. That step gets the GITHUB_TOKEN that semantic-trusted-release uses, and the job runs with id-token: write in the npm-trusted-publisher environment, so this touches credential handling. A CODEOWNERS rule (*) covers every file in the repo, including this one. I couldn't confirm the new SHA against the upstream tag, so I deferred instead of approving.
MarshallOfSound
approved these changes
Oct 22, 2026
MarshallOfSound
enabled auto-merge (squash)
October 22, 2026 21:41
dsanders11
approved these changes
Oct 22, 2026
jkleinsc
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.
Generated by Claude Code