Repository navigation
build(deps-dev): bump electron from 43.7.5 to 43.8.1 - #490
Conversation
Bumps [electron](https://github.com/electron/electron) from 43.7.5 to 43.8.1. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v43.7.5...v43.8.1) --- updated-dependencies: - dependency-name: electron dependency-version: 43.8.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
| version: 43.8.3 | ||
| resolution: "electron@npm:43.8.3" | ||
| dependencies: | ||
| "@electron-internal/extract-zip": "npm:^1.0.1" | ||
| "@electron/get": "npm:^5.0.0" | ||
| "@types/node": "npm:^24.9.0" | ||
| bin: | ||
| electron: cli.js | ||
| install-electron: install.js | ||
| checksum: 10c0/4f2e3070c0b791a752c21334b7264f29b1ff9f218fac822b67ffdaa4ee964e394ea502858947ec14b705e495ebcf07fcc09e7304ed9c1a8b808c701416a0a90e | ||
| checksum: 10c0/2c3b38ddf609aaf481d150403716ba23d205b57658415a0e579a1e62f09649be14a5e7926a58574da4fd63a68fea25da8855cfc9a0fc67fad5387f83058b03d9 |
There was a problem hiding this comment.
🔴 Reviewers who approve this as the electron 43.8.1 security bump would merge a different, unreviewed release, 43.8.3, into every install and CI run. The lock entry at yarn.lock:728-737 resolves electron@ npm:43.8.3 with a new checksum. The commit message and its dependency-version: 43.8.1 metadata both say 43.8.1. Dependabot writes the message and the lockfile together, so this mismatch inside one commit is unexpected. Fix: make the lockfile and the PR metadata name the same version. Either regenerate the lock at 43.8.1, or have Dependabot recreate the PR for 43.8.3, and confirm the checksum against a clean yarn install.
Why this was flagged
HEAD commit 3781179 is signed off by dependabot[bot]. Its message says "bump electron from 43.7.5 to 43.8.1" and its trailer says dependency-version: 43.8.1. Its only change, to yarn.lock:728-737, sets version: 43.8.3, resolution: "electron@ npm:43.8.3" and checksum 10c0/2c3b38dd…. The release notes and GHSA-jr5w-w6x2-84p9 that reviewers are shown cover 43.8.1, not 43.8.3. Nothing in the repo would flag the mismatch. .yarnrc.yml lists electron under npmPreapprovedPackages, so the npmMinimalAgeGate: 10080 cooling-off period does not apply to it. package.json dependenciesMeta.electron.built: true lets electron's install.js run even though enableScripts: false is set. So whatever tarball matches this checksum is downloaded and its install script runs on every yarn install and in CI (xvfb-maybe electron ... in the test script). On the base branch the lock pins the reviewed 43.7.5. I could not query the registry from this sandbox. I therefore could not confirm that 43.8.3 is a legitimate published release or that the checksum matches it.
Verification: HEAD commit 3781179 (author dependabot[bot]) has the message "bump electron from 43.7.5 to 43.8.1", but yarn.lock lines 728-729 set resolution: "electron@ npm:43.8.3". So the version that merges and runs in every install and CI job is 43.8.3. .yarnrc.yml lists "electron" under npmPreapprovedPackages, so the age gate does not apply.
|
@SocketSecurity ignore npm/electron@43.8.3 |
Bumps electron from 43.7.5 to 43.8.1.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
817c43ffix: apply the certificate SPKI blocklist to Node and add entries (43-x-y) (#...9afe078docs: fix code block line highlighting after docs reformats (#55103)076d6dbtest: replace fix_crypto_tests_to_run_with_bssl.patch with upstream backport ...3b068bftest: re-enable Node.js tests that now pass with BoringSSL (#55094)60f928ebuild: stop overriding node GN declare_args defaults in patch (#55076)14c73d1build: update PGO profiles (#55092)7ceb2c0fix: avoid misaligned char16_t reads in crdtp string deserialization (#55063)06f1c1fci: use Cloudflare DNS directly on macOS runners (#55068)a68de91fix: use the opener's session and webPreferences for windows opened from link...6a2b850ci: skip native builds when installing deps for type generation (#55065)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.