Repository navigation
chore: remove leftovers, pin actions - #469
Conversation
Remove the changesets versioning workflow (changesets/action without a publish input, which only added a Release check to every commit on main), the generated .changeset/README.md and the root CHANGELOG.md stub. changeset publish stays the publish command. Refs #465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The builder stage of the docs image copies the whole build context. Send only what the build needs (allow list: workspaces, build scripts, root manifests), so that local .env* files and other local files never reach the image, and drop dependencies and build output within. Closes #463 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pin every action to a full commit SHA on its current major version (checkout v7, setup-node v7, cache v6, semantic PR title v6, ssh-agent v0.10, push action v1.3.0 instead of master), with Dependabot keeping the pins up to date. Replace the node_modules caches, whose key hashed a file that doesn't exist and which used ::set-output, by the npm cache of setup-node in CI; releases use no dependency cache. Drop the force-with-lease input of the push action, which doesn't exist (the input is force_with_lease) and so never had an effect. Refs #465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Give Dependabot pull requests a ci: prefix, so that their titles pass the PR title check. Keep the commented-out release tests job as it was and state the release cache comment once. Refs #465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Reviewer's GuideThis PR tightens the Docker build context, removes obsolete Changesets leftovers, hardens workflow supply-chain dependencies with SHA-pinned actions and Dependabot maintenance, and fixes CI/release caching while pinning tests to Ubuntu 24.04 for current Playwright compatibility. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
ubuntu-latest now is Ubuntu 26.04, on which Playwright 1.56 can't install its browsers, so every test job fails (unrelated to the other changes). Pin the test job to ubuntu-24.04 until Playwright is upgraded. Refs #465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The release workflow now runs pinned action revisions while holding deployment and npm credentials; if a selected revision behaves incorrectly, it could push an unintended commit or publish a bad package. Reverting restores the workflow but cannot retract packages already published or commits already pushed.
Summary
First of four stacked pull requests for #464 (merge in order: this one, then Node.js 22/24, trusted publishing, CI gate). Nothing changes in the maintainer flow: direct pushes to
mainand av*tag to release keep working..dockerignore(allow list) for the docs image: onlyapps/,packages/,scripts/,package.json,package-lock.jsonandturbo.jsonreach the build context;.env*(except.env.example),node_modulesand build output are excluded within them. The context shrinks to 3.8 MB..github/workflows/version.yml(changesets/action withoutpublish, which only added aReleasecheck to every commit onmain),.changeset/README.md, the rootCHANGELOG.mdstub.changeset publish(npm run release) and.changeset/config.jsonstay.master, which was used unpinned with the deploy key). Dependabot keeps the pins current (.github/dependabot.yml, GitHub Actions only, monthly, one grouped PR titledci: …).node_modulescaches keyed on a nonexistentpackage.lock(and their::set-output) are replaced by the npm cache ofsetup-nodein CI; the release workflow uses no dependency cache (cache poisoning;packageManagerwould otherwise turn it on). Theforce-with-leaseinput of the push action is dropped: the action only knowsforce_with_lease, so it was never in effect (no behaviour change).Closes #463
Closes #465
Verification
npm ci,npm run lint(includes the build): pass (Node.js 22, locally).docker build .: passes. With.env.localfiles at the root and inapps/documentation, the builder stage (--target builder) contains neither, but keepsapps/documentation/.env.example.git ls-remote.Semantic PR title,Detect unresolved merge conflictsandLinting checkspass.Test checksfail for reasons that are not caused by this PR (they fail on Dependabot PRs too):ubuntu-latestis now Ubuntu 26.04, where Playwright 1.56 can't install its browsers. Fixed here (see Unrelated fixes).@elixir-cloud/wes) fail withCould not find any test files with pattern(s): src/**/**/*.test.ts. feat: add surface, font and dark mode controls #446 fixes the test scripts; once it is merged, update this branch and the tests should run.Vercelfails on this PR as on others; docs hosting is being moved and is out of scope.Unrelated fixes
ci: run tests on Ubuntu 24.04: pins the test job's runner until Playwright is upgraded.Declined review findings
!.npmrcto the.dockerignoreallow list:turbo prune --dockernever copied the root.npmrcintoout/, its only setting (auto-install-peers) is ignored by npm, and the image builds.ci: bump the github-actions group with N updates) fits.Maintainer steps (after merge)
🤖 Generated with Claude Code
Summary by Sourcery
Clean up obsolete release artifacts, harden GitHub Actions dependencies, and improve CI and Docker build reliability.
Bug Fixes:
Enhancements:
CI: