Repository navigation
test: drop test scripts of packages without tests - #478
Merged
Merged
Conversation
Web Test Runner exits with an error when it finds no test files, so `npm run test` failed in every package that had a `test` script but no tests. Remove the script from those packages, as ro-crate and tes already do; turbo skips packages without it. Closes #477 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uniqueg
marked this pull request as ready for review
October 27, 2026 02:32
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Web Test Runner exits with an error when it finds no test files ("Could not find any test files with pattern(s): src///*.test.ts"), so
Test checksfailed on every PR. This removes thetestscript from the packages that have no tests: cloud-registry, drs-filer, trs-filer, drs, service-registry, trs, wes and design.@elixir-cloud/ro-crateand@elixir-cloud/tesalready have notestscript; turbo skips packages without it.Web Test Runner 0.19 has no option to pass when no tests are found, so removing the script is the cleanest fix. It is what #446 does too. #446 also adds tests to wes and design, together with unrelated theming work, and is on hold; this PR splits out only the script fix. #446 will get a small conflict in the
testlines ofpackages/ecc-client-ga4gh-wes/package.jsonandpackages/ecc-utils-design/package.json(keep #446's version).test:watch/test:componentstay as they are, as in #446.Closes #477
Verification
Run in a fresh clone on top of
origin/dev, Node 22, the same steps as theTest checksandLinting checksjobs:npm ci: passednpm run build: passed (9/9 tasks)npm run test: passed (exit 0; no package has atestscript now, so no tasks run). Ondevit fails with the error above.npm run lint: passed (19/19 tasks)npx prettier --check packages/*/package.json: passedCI:
PR Evaluation(withTest checks) doesn't run on this PR, because ondevit only triggers for PRs tomain; #470 and the PRs stacked on it change that. TheirTest checksfail with exactly the error this PR removes (@elixir-cloud/trs#test,@elixir-cloud/wes#test). Read the Docs fails for the known unrelated reason (#476 sets it up).Light lane: this only removes 8 npm script entries (test configuration), no code or workflow changes, so I reviewed the diff myself instead of running the reviewer subagents.
Notes
testscript has tests.@elixir-cloud/teshas test files but notestscript; that's out of scope here and should get its own issue.🤖 Generated with Claude Code