Skip to content

test: drop test scripts of packages without tests - #478

Merged
uniqueg merged 1 commit into
devfrom
test/pass-without-tests
Oct 27, 2026
Merged

uniqueg merged 1 commit into
devfrom
test/pass-without-tests

Conversation

@uniqueg

@uniqueg uniqueg commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Summary

Web Test Runner exits with an error when it finds no test files ("Could not find any test files with pattern(s): src///*.test.ts"), so Test checks failed on every PR. This removes the test script from the packages that have no tests: cloud-registry, drs-filer, trs-filer, drs, service-registry, trs, wes and design. @elixir-cloud/ro-crate and @elixir-cloud/tes already have no test script; turbo skips packages without it.

Web Test Runner 0.19 has no option to pass when no tests are found, so removing the script is the cleanest fix. It is what #446 does too. #446 also adds tests to wes and design, together with unrelated theming work, and is on hold; this PR splits out only the script fix. #446 will get a small conflict in the test lines of packages/ecc-client-ga4gh-wes/package.json and packages/ecc-utils-design/package.json (keep #446's version).

test:watch / test:component stay as they are, as in #446.

Closes #477

Verification

Run in a fresh clone on top of origin/dev, Node 22, the same steps as the Test checks and Linting checks jobs:

  • npm ci: passed
  • npm run build: passed (9/9 tasks)
  • npm run test: passed (exit 0; no package has a test script now, so no tasks run). On dev it fails with the error above.
  • npm run lint: passed (19/19 tasks)
  • npx prettier --check packages/*/package.json: passed

CI: PR Evaluation (with Test checks) doesn't run on this PR, because on dev it only triggers for PRs to main; #470 and the PRs stacked on it change that. Their Test checks fail with exactly the error this PR removes (@elixir-cloud/trs#test, @elixir-cloud/wes#test). Read the Docs fails for the known unrelated reason (#476 sets it up).

Light lane: this only removes 8 npm script entries (test configuration), no code or workflow changes, so I reviewed the diff myself instead of running the reviewer subagents.

Notes

  • After this PR, CI runs no tests at all, because no package with a test script has tests. @elixir-cloud/tes has test files but no test script; that's out of scope here and should get its own issue.
  • Vercel and Read the Docs checks may fail for known reasons unrelated to this PR.

🤖 Generated with Claude Code

Web Test Runner exits with an error when it finds no test files, so
`npm run test` failed in every package that had a `test` script but no
tests. Remove the script from those packages, as ro-crate and tes
already do; turbo skips packages without it.

Closes #477

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@uniqueg
uniqueg marked this pull request as ready for review October 27, 2026 02:32
@uniqueg
uniqueg merged commit 4f849f7 into dev Oct 27, 2026
1 of 2 checks passed
@uniqueg
uniqueg deleted the test/pass-without-tests branch October 27, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: pass packages without tests

1 participant