Repository navigation
Add end-to-end suite - #36
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Environment leakage, an unbounded download, and cross-run rate-limit collisions can make the suite unreliable.
3 open findings
What changed in this PR
Adds live API end-to-end coverage for the compiled CLI.
Changes:
- Adds account, verification, batch, download, and rate-limit tests.
- Runs E2E tests across Linux, macOS, and Windows.
- Documents the new Make target and required test key.
| File | Description |
|---|---|
README.md |
Documents E2E test usage. |
Makefile |
Adds the test-e2e target. |
e2e/e2e_test.go |
Implements the live API test suite. |
.github/workflows/e2e.yml |
Runs the suite in GitHub Actions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…al API with a test key. The stub tests encode what we believe the API returns, so they can't catch the API changing underneath the CLI.
… a few test addresses. Also match the real API: an unknown key returns 403, and the free and accept-all flags turn a deliverable result risky.
…dows in the e2e suite, and drop the credit check since test keys never spend credits.
…o` downloads the results file.
…verrides, and bound the download with a timeout.
jclusso
force-pushed
the
live-e2e-suite
branch
from
October 7, 2026 19:54
5a8e9a5 to
f21df03
Compare
jclusso
marked this pull request as ready for review
October 7, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stub tests encode what we believe the API returns, so they can't catch the API changing underneath the CLI. This runs the built binary against the real API with a test key on every PR and push to
master, and skips whenEMAILABLE_TEST_API_KEYisn't available.