Repository navigation
Fix boolean table values in options table passed to luaRunFile - #28
Merged
Merged
Conversation
luaMacrosFromTable in luaEpics.cpp tried converting each value
in the table to a string, regardless of its actual type and
this fails for booleans. This commit fixes this by explicity
checking the type and manually converting boolean true to "true"
and false to "false". This allows us to pass {async = true}
as the options table for luaRunFile as advertised in the
documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
luaMacrosFromTablein luaEpics.cpp tries converting each value in the table to a string, regardless of its actual type and this fails for booleans (result will beNULL)lua/luaApp/src/luaEpics.cpp
Line 655 in ada11c0
Because of this, passing
{async = true}as an options table toluaRunFilefails silently (but{async = 1}works) as described in the docs here:lua/docs/using-lua-shell.md
Line 149 in ada11c0
This commit fixes this by explicitly checking the type and manually converting boolean true to "true" and false to "false". This allows us to pass
{async = true}as the options table forluaRunFileas advertised in the documentation.Assisted-by: GPT-5.6 Sol