Let the ASR and ST demos run on either OWSM v4 - #63
Merged
Merged
Conversation
One line at the top, as the POWSM notebook has: MODEL, with the encoder-decoder named beside it. Both decode through decode_long, which takes either checkpoint, so nothing else had to change - what was missing was the reader knowing they could. asr_demo also says what best_path means on each: the whole model on the encoder-only checkpoint, and the CTC branch on the encoder-decoder, which answers what that branch was trained on rather than what the task asks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same one-line switch the POWSM notebook got (#62), now for the two OWSM demos:
and nothing else to change. Both notebooks decode through
decode_long, which works on either checkpoint, so the swap needed no other edit — the value is in saying that it is a swap, since a reader who wants the encoder-decoder currently has no hint that this notebook would run it.asr_demoalso gains a caveat where it usesbest_path: on the encoder-only checkpoint that is the whole model, but on the encoder-decoder it reads the CTC branch, which answers what that branch was trained on rather than what the task symbol asks for. A reader who swaps the tag and keeps reading would otherwise conclude the model is confused.Verified: both run top to bottom against espnet master —
RESULT okfor each.🤖 Generated with Claude Code