Repository navigation
Conversation
A compiler group is now explicit when some view exposes it (uenv:add_compilers), which makes it a gc root and lets spack generate its module file. uenv_tools is always explicit so gc cannot collect squashfs before the image step; its module is excluded unless the recipe asks for squashfs itself. Follow-ons: compiler-config.py drops an explicit=False filter that would match nothing once groups are explicit; envvars.py sets CC/CXX/FC/F77 (spack only does so for compilers it installed, not externals) and clears them for a view that exposes no compilers, where they pointed at symlinks nothing creates.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A compiler group is now explicit when some view exposes it (uenv:add_compilers), which makes it a gc root and lets spack generate its module file. uenv_tools is always explicit so gc cannot collect squashfs before the image step; its module is excluded unless the recipe asks for squashfs itself.
Follow-ons: compiler-config.py drops an explicit=False filter that would match nothing once groups are explicit; envvars.py sets CC/CXX/FC/F77 (spack only does so for compilers it installed, not externals) and clears them for a view that exposes no compilers, where they pointed at symlinks nothing creates.
Fixes #307