Skip to content

7.x.x/hotfix/declare context item analyze attempt #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Laurettta wants to merge 2 commits into from
Closed

7.x.x/hotfix/declare context item analyze attempt #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fefcec
[bugfix] Raise XPTY0004 when declare context item is not given exactl…
Laurettta Oct 30, 2026
48c83b5
[ignore] ContextItemDeclaration.analyze() which is never called
Laurettta Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions exist-core/src/main/java/org/exist/xquery/ContextItemDeclaration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ public void analyze(final AnalyzeContextInfo contextInfo) throws XPathException

if (value.isPresent()) {
value.get().analyze(contextInfo);
if (!value.get().getCardinality().atMostOne()) {
throw new XPathException(this, ErrorCodes.XPTY0004, "The context item must be exactly one item");
}

}
}

Expand All @@ -77,6 +81,14 @@ public Sequence eval(final Sequence contextSequence, final Item contextItem) thr
}
} else {
return value.get().eval(null, null);

// else {
// final Sequence result = value.get().eval(null, null);
// if (result.isEmpty() || result.hasMany()){
// throw new XPathException(this, ErrorCodes.XPTY0004,"The context item must be exactly one item");
// } else {
// return result;
// }
}
}

Expand Down
19 changes: 17 additions & 2 deletions exist-core/src/test/java/org/exist/xquery/XQueryDeclareContextItemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@
import java.util.Optional;
import java.util.Properties;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.*;

/**
* Tests for XQuery 3.0's declare context item
Expand Down Expand Up @@ -144,6 +143,22 @@ public void declareContextItem() throws EXistException, PermissionDeniedExceptio
}
}

@Test
public void declareContextItemMoreThanOneItem() throws EXistException, PermissionDeniedException, XPathException, IOException {
final String query =
"xquery version \"3.0\";\n" +
"declare context item := (1,2); \n" +
".";

final BrokerPool pool = existEmbeddedServer.getBrokerPool();
try (final DBBroker broker = pool.getBroker();
final XQueryUtil.QueryResult queryResult = XQueryUtil.query(broker, new StringSource(query), false, null, null, null, null, null)) {
fail("Expected XQuery error XPTY0004");
} catch (final XPathException e){
assertEquals(ErrorCodes.XPTY0004, e.getErrorCode());
}
}

/**
* See issue https://github.com/eXist-db/exist/issues/2156
*/
Expand Down
Loading