Repository navigation
Minitest: Initialize test runs before checking retry expiry - #102
Merged
Merged
Conversation
ckwarteng
marked this pull request as ready for review
October 5, 2026 17:32
ckwarteng
requested review from
a team,
michaelnyu,
pratham-figma and
yfang-figma
and removed request for
a team
October 5, 2026 17:37
ckwarteng
changed the title
ebarajas
reviewed
Oct 5, 2026
|
|
||
| def expired? | ||
| (@created_at.to_f TEN_MINUTES) < CI::Queue.time_now.to_f | ||
| (@created_at.to_f + TEN_MINUTES) < CI::Queue.time_now.to_f |
Contributor
There was a problem hiding this comment.
lol i really hate ruby sometimes
ebarajas
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by AI, edited by me
Buildkite can retry a job before it ever reaches
minitest-queue. The runner checks retry expiry before initializing the run timestamp, interprets the missing timestamp as expired data, and aborts with "The test run is too old and can't be retried". We fix this by initializing the run timestamp before checking retry expiry. Initialization only writes a missing timestamp, preserving the original age of existing runs.In the example Figma build, the original worker was spot-terminated during setup, before
Run tests. Both replacement attempts hit this error despite the build being only minutes old.Validation
< 3for compatibility with its existing ActiveSupport 5.2 fixture; this does not change the packaged runtime dependencies.