Skip to content

INTER-781: Document commit conventions and release process in contributing.md - #57

Open
erayaydin wants to merge 5 commits into
mainfrom
docs/contributing-release-process-inter-781
Open

erayaydin wants to merge 5 commits into
mainfrom
docs/contributing-release-process-inter-781

Conversation

@erayaydin

@erayaydin erayaydin commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Expands contributing.md so contributors know how to write commit messages and how releases are made. This only changes the contributing.md file.

  • Commit messages: links to Conventional Commits and the commitlint config that the Analyze Commit Messages check uses.
  • Git hooks: Optional hooks from install_hooks.sh (commit-msg runs commitlint, pre-push tries to stop accidental pushes to main); commit messages are also checked in CI.
  • How to publish: how to add a changeset, how to pick patch/minor/major based on the type of change and what that does to the version, and what happens after merge (Release [changeset] PR, tag, publish to JitPack).

Explain commit types, scopes and breaking change syntax with examples, document the Git
hooks, and describe how changesets decide versions and drive releases.

Related-Task: INTER-781
@erayaydin
erayaydin force-pushed the docs/contributing-release-process-inter-781 branch from 145acd2 to de4c845 Compare October 7, 2026 15:28
@erayaydin
erayaydin requested a balanced review from Copilot October 7, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Git hook documentation contradicts the repository’s existing optional commit hook and installer.

1 open finding
What changed in this PR

Expands contributor guidance for commit conventions and the SDK release process.

Changes:

  • Documents Conventional Commit formats, types, breaking changes, and examples.
  • Explains changeset creation, version bumps, and release automation.
  • Adds Git hook guidance, though it incorrectly states none exist.
File Description
contributing.md Documents commit messages, changesets, and releases.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread contributing.md Outdated
Document the optional hooks from install_hooks.sh, narrow the changeset criterion to
public API or behavior changes, and make the breaking change row cover any <type>! commit.

Related-Task: INTER-781

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Git hook setup and protection claims do not match the repository’s actual configuration and behavior.

2 open findings
1 resolved since last review

🧠 Review effort: Balanced

Comment thread contributing.md
Comment thread contributing.md Outdated
Soften the pre-push hook description, run pnpm install before install_hooks.sh, and
clarify that only PRs with changesets open the release PR.

Related-Task: INTER-781

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation accurately reflects the repository’s hooks, CI checks, and release workflows.

0 open findings

2 resolved since last review

🧠 Review effort: Balanced

@erayaydin
erayaydin marked this pull request as ready for review October 7, 2026 16:48
mcnulty-fp
mcnulty-fp previously approved these changes Oct 7, 2026

@mcnulty-fp mcnulty-fp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left just one nit

Comment thread contributing.md Outdated
Replace the commit format details with links to Conventional Commits and the commitlint
config, since they are not SDK-specific.

Related-Task: INTER-781
Make Git hooks a sibling of the Commit messages heading, since the hooks cover more than
commit messages.

Related-Task: INTER-781
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@erayaydin
erayaydin requested a review from mcnulty-fp October 8, 2026 08:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants