Skip to content

INTER-783: Document commit conventions and release process in contributing.md - #238

Open
erayaydin wants to merge 5 commits into
mainfrom
docs/contributing-release-process-inter-783
Open

erayaydin wants to merge 5 commits into
mainfrom
docs/contributing-release-process-inter-783

Conversation

@erayaydin

@erayaydin erayaydin commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Expands contributing.md so contributors know how to write commit messages and how releases are made. This only changes the contributing.md file.

  • Commit messages: links to Conventional Commits and the commitlint config that the Analyze Commit Messages check uses.
  • Git hooks: The two optional setups, install_hooks.sh (commitlint, accidental push guard) and pre-commit (Ruff, MyPy), and that only one can be used at a time.
  • How to publish: how to add a changeset, how to pick patch/minor/major based on the type of change and what that does to the version, and what happens after merge (Release [changeset] PR, tag, publish to PyPI).

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
3314 2388 72% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 9c287c8 by action🐍

Explain commit types, scopes and breaking change syntax with examples, document the Git
hooks, and describe how changesets decide versions and drive releases.

Related-Task: INTER-783
@erayaydin
erayaydin force-pushed the docs/contributing-release-process-inter-783 branch from fb60067 to b58a8df Compare October 7, 2026 15:28
@erayaydin
erayaydin requested a balanced review from Copilot October 7, 2026 15:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only minor documentation clarifications remain, with no blocking issues identified.

1 open finding
What changed in this PR

Expands contributor guidance for commit conventions and the SDK release process.

Changes:

  • Documents commit types, scopes, breaking changes, and examples.
  • Adds local hook installation instructions.
  • Explains changesets, version bumps, and the release-to-PyPI workflow.
File Description
contributing.md Expands commit, hook setup, and release guidance.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread contributing.md Outdated
Document the optional hooks from install_hooks.sh, narrow the changeset criterion to
public API or behavior changes, and make the breaking change row cover any <type>! commit.

Related-Task: INTER-783

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The hook setup instructions omit a dependency needed for commits to succeed on a fresh checkout.

2 open findings
1 resolved since last review

🧠 Review effort: Balanced

Comment thread contributing.md Outdated
Comment thread contributing.md
Soften the pre-push hook description, run pnpm install before install_hooks.sh, and
clarify that only PRs with changesets open the release PR.

Related-Task: INTER-783

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes address prior feedback, with no unresolved blocking issues identified.

0 open findings

2 resolved since last review

🧠 Review effort: Balanced

@erayaydin
erayaydin marked this pull request as ready for review October 7, 2026 16:48
TheUnderScorer
TheUnderScorer previously approved these changes Oct 7, 2026
Replace the commit format details with links to Conventional Commits and the commitlint
config, since they are not SDK-specific.

Related-Task: INTER-783
Make Git hooks a sibling of the Commit messages heading, since the hooks cover more than
commit messages.

Related-Task: INTER-783
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants