Repository navigation
fix: clamp TrueBlockValue payout to relay max_bid_eth - #938
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
Apply per-relay max_bid_eth from relay submit config when constructing TrueBlockValue slot bids so funded coinbase balance cannot inflate payouts above the operator cap. Fixes flashbots#700
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_bid_ethfrom each relay''s submit config and clampNewTrueBlockValueSlotBidderpayout values before sealing bids.Test plan
cargo fmt --all --check(WSL, rbuilder workspace)cargo test -p rbuilder --lib true_value_bidding_service -- --test-threads=2(WSL; fullrbuilderlib compile was in progress when PR opened; CI should run checks)max_bid_for_relay_set_requires_cap_on_every_relay,clamp_payout_respects_relay_max_bidFixes #700