Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2273.
Since #2166, a tile that fails to load is marked
readyToDisplayeven without anerrorImage, soTileImageView.renderTilesstops keeping the loaded tiles of other zoom levels in its place and the map goes blank, for example when zooming in offline.A failed tile without
errorImagenow stays not ready to display, as before #2166, but still notifies its listeners, sotileBuilderis still called with the failed tile. The assertion #2166 removed from_displayis back.The new widget tests cover a failed tile without
errorImage(fallback tiles drawn), withtileBuilder(builder gets the failed tile, fallback tiles drawn), and witherrorImage(error image drawn, unchanged).