Repository navigation
Conversation
…r zoom level `contains` compared x/y only. `TileImageView` checks the coordinates of every loaded level against ranges of the target level, so a tile of another level whose x/y fell in the range was rendered and kept as if it were visible, even with every target tile ready. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Heads-up: with the default transformer on Epsg3857, the modulo in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2269 (step 1 of the split).
DiscreteTileRange.containscompares x/y only.TileImageViewchecks the coordinates of every loaded level against ranges of the target level (renderTiles,staleTiles,_errorTilesWithinRange), so a tile of another level whose x/y fall in the range is rendered and kept as if it were visible — even with every target tile ready. With a ×2 grid that only happens near the origin; with other ratios, anywhere.One line: a
TileCoordinatesat another zoom is never contained. PlainPoints are unaffected.Tests:
tile_range_test.dart(contains),tile_image_view_test.dart— on master a ready z9 tile is inrenderTileswhile all four visible z10 tiles are ready; not with the fix. Full suite passes (141).🤖 Generated with Claude Code