Repository navigation
fix: clear[] crashed after a fire whose front had stopped - #194
Open
yanissrairi wants to merge 1 commit into
Open
yanissrairi wants to merge 1 commit into
yanissrairi wants to merge 1 commit into
Conversation
When the last event is taken out of the TimeTable, getUpcomingEvent left head pointing at it. If that event then had an infinite time (its node stopped), insert() deleted it and head dangled, so clear() deleted it a second time. dropAtomEvents could likewise delete the event being processed.
yanissrairi
force-pushed
the
fix/timetable-dangling-head
branch
from
October 5, 2026 12:09
545bbef to
1b011b7
Compare
Contributor
|
thanks @yanissrairi the clear[] hasn't been much tested yet. My problem is testing it into a coupled fire/atmospher context with MPI and Fortan bindings, which i have no time to do yet.. very sorry. I'll be back on these around Oct 20. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a fire's front stops everywhere (e.g. an ignition in non-burnable fuel), the next
clear[]segfaults.getUpcomingEventtook the last event out but leftheadpointing at it. The stopped node's event has an infinite time, soinsert()deleted it, andclear()deleted it again throughhead. The fix setshead = nullptrin that branch.Reproduction, from
tests/runff:Added
tests/unit/test_timetable.cpp, which crashes without the fix.ctestandrunffpass.