Repository navigation
fix: draw no-overlay surveys above elevated host views on Android [ENG-3971] - #85
Conversation
…G-3971] A no-overlay survey renders in the host's view tree since ENG-3156, and Android draws elevated siblings (Buttons, cards, tab bars) above views without elevation. Give the survey layer zIndex and elevation so the card stays on top.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe survey wrapper now uses a named style instead of the inline absolute-fill style. The named style retains absolute fill and adds z-index and elevation values. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: fixing the rendering order of no-overlay surveys above elevated Android host views. Description check The description directly explains the Android rendering issue, the zIndex and elevation fix, validation results, and remaining coverage gaps. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
2 participants
Fixes ENG-3971
What & why
Was: on Android, a survey with no overlay was drawn under any app view with elevation (RN
Button, cards, tab bars). Those views covered the card's heading, options or Next button, while taps on them still went to the survey. Regression from #81; 3.2.0 is not affected.Now: the card is drawn above the app again, as it is with overlay placements. Touches outside the card still reach the app.
Android sorts siblings by elevation before tree order, and #81 moved no-overlay surveys from a
<Modal>into the host's view tree. The<Formbricks />wrapper now carrieszIndexandelevation. It is transparent, so the elevation casts no shadow.Where to look
packages/react-native/src/components/formbricks.tsx: thelayerstyle on the wrapper.Coverage
pnpm test(225 passed)Screenshots (Android, bottom-right placement, no overlay)
Open gaps
zIndexonly).maindoes not bundle in Expo Go as-is (RN 0.84 vs Expo Go's 0.83, plus the SDK's ESM build inliningreact/jsx-runtime). I aligned versions locally for the run; nothing of that is in this diff.Ran locally:
pnpm lint,pnpm check-types,pnpm test.