Repository navigation
Fix Ashby plugin crash on null secondary location address - #703
Merged
andreugordillovazquez merged 1 commit intoOct 9, 2026
Merged
Conversation
Ashby job boards can return null for secondaryLocations[].address (e.g. artemis "Remote"), which failed validation even though primary job address was already nullable.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
triozer
approved these changes
Oct 9, 2026
triozer
added
the
Auto submit to Marketplace on merge
andreugordillovazquez
deleted the
fix/ashby-null-secondary-location-address
branch
October 9, 2026 10:22
andreugordillovazquez
had a problem deploying
to
production
October 9, 2026 10:22 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullforsecondaryLocations[].address(seen on theartemisboard for a"Remote"secondary location).SecondaryLocationSchemarequired an object, so Valibot failed withInvalid type: Expected Object but received nulland the plugin threw "Error parsing Ashby data". Primaryaddresswas already nullable; secondary locations were not.nullfor secondary locationaddress. Downstream code (extractLocation, location refs vialocationslug) already handles null addresses.artemis— any Ashby board that omits a secondary address would hit the same bug. Boards without null secondary addresses continue to parse as before.Test plan
SecondaryLocationSchema/JobSchemawith null secondary addressartemisjob board response successfully after the fix (fails with the old schema)notion,linear, andopenaiboards successfully (no regressions)yarn check-vitest,check-typescript,check-biome,check-eslintinplugins/ashby