Skip to content

chore(flake/precommit): d95ac632 -> 1b327ca4 - #74

Merged
fredclausen merged 2 commits into
mainfrom
update-precommit
Nov 1, 2026
Merged

fredclausen merged 2 commits into
mainfrom
update-precommit

Conversation

@fredclausen

@fredclausen fredclausen commented Nov 1, 2026 •

Copy link
Copy Markdown
Member
Commit Message
1b327ca4 chore(flake/nixpkgs): 02c087f3 -> 31ecbaca
33516b63 chore(flake/rust-overlay): b0829a2c -> 96a0986b
583246b4 chore(flake/nixpkgs): 55bfb4d7 -> 02c087f3
d785f3e8 chore(flake/rust-overlay): ec07af44 -> b0829a2c
e04ae0e3 chore(flake/rust-overlay): 4ca29632 -> ec07af44
b6d57063 chore(flake/nixpkgs): e7439b6b -> 55bfb4d7
a52817af chore(flake/git-hooks): a0e4241b -> 1ba1dbfe
ac66746a chore(flake/flake-utils): 11707dc2 -> b7a79d3f
d77a042c chore(flake/nixpkgs): c59305ba -> e7439b6b
960fcb8e chore(flake/rust-overlay): 368fee9b -> 4ca29632
36c0c2e9 chore(flake/nixpkgs): 4975466d -> c59305ba
9e38a02b chore(flake/rust-overlay): 84fb3c79 -> 368fee9b
21fb8f8f chore(flake/git-hooks): 0d3997c4 -> a0e4241b

Summary by CodeRabbit

  • Tests
    • Updated test checks to compare empty and nonempty outputs and collections directly. No application behavior changed.

Copilot AI balanced review requested due to automatic review settings November 1, 2026 03:14
@fredclausen
fredclausen enabled auto-merge (rebase) November 1, 2026 03:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

Tests now compare values directly with expected empty or nonempty values. No runtime behavior or public declarations changed.

Changes: Test assertion updates

Layer / File(s) Summary
Direct value comparisons
crates/fredshell-ansi/src/decode.rs, crates/fredshell-core/src/exec/*, crates/fredshell-core/src/repl.rs, crates/fredshell-core/src/tty/*, crates/fredshell-spec-runner/src/*, crates/fredshell-spec-runner/tests/smoke.rs, xtask/src/check_specs.rs
Tests replace emptiness checks with direct comparisons to expected empty or nonempty values. Other assertions remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 238c6

No actionable merge-blocking risk remains.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

The precommit bump brings Rust 1.99, whose pedantic set adds
clippy::assert_is_empty. Compare against an empty value instead of
asserting is_empty() so a failing assertion prints the actual contents.
@fredclausen
fredclausen merged commit abc2da6 into main Nov 1, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants