Skip to content

Refactor invalid option tests to table-driven tests - #885

Merged
fxamacker merged 1 commit into
masterfrom
fxamacker/refactor-options-test-to-use-test-table
Oct 24, 2026
Merged

Refactor invalid option tests to table-driven tests#885
fxamacker merged 1 commit into
masterfrom
fxamacker/refactor-options-test-to-use-test-table

Conversation

@fxamacker

@fxamacker fxamacker commented Oct 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

No changes to non-test code. Coverage is unchanged.

  • diff: $\color{green}{\mathsf{+142}}$ $\color{red}{\mathsf{-897}}$
  • coverage: 97.7% of statements

@fxamacker fxamacker self-assigned this Oct 24, 2026
@fxamacker fxamacker added the tests Unit tests label Oct 24, 2026
x448
x448 approved these changes Oct 24, 2026
View reviewed changes

@x448 x448 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 👍

@fxamacker
fxamacker merged commit ba35f5a into master Oct 24, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@x448 x448 x448 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fxamacker fxamacker

Labels

tests Unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fxamacker @x448