Repository navigation
Accept request records and optional providers for Voronoi complexes - #167
Merged
grahamknockillaree merged 4 commits intoOct 23, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 43.15% 43.15% -0.01%
==========================================
Files 371 372 +1
Lines 67887 67974 +87
==========================================
+ Hits 29296 29331 +35
- Misses 38591 38643 +52
🚀 New features to boost your workflow:
|
Member
Author
|
To be quick, Julia CI most probably needs a dedicated runner, where starting up Julia with all its needed dependencies (Oscar, Nemo, GAP, etc) takes long time. (Oscar project does have such runners, so it's matter of them lending the use of one of them here). Currently that run took 10 minutes, 7 of them was spent on on loading/compiling dependencies. |
dimpase
marked this pull request as ready for review
October 23, 2026 01:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables Voronoi-complex and group-homology computations entirely from a Julia session, without Magma. ArithmeticVoronoi uses Julia/OSCAR to construct the complexes for arithmetic groups (currently quadratic GL₂ and imaginary-quadratic SL₂ over maximal orders on the free rank-two lattice), then calls HAP through GAP.jl to compute homology.
The group range can be extended, it's just what we have working now.
HAP's existing Voronoi constructors use Magma/VMH. This adds
VoronoiComplex(request : backend := name)and a provider registry, so external implementations can supply HAP non-free resolution objects.Providers receive one record:
HAP passes the record unchanged. Providers interpret and validate its contents, including any field polynomials, order bases, lattice ideals or subgroup data they support. The dispatcher imposes no field-degree, rank or group-family restriction. A provider returns a HAP non-free resolution, returns
fail, or raises an explanatory error for unsupported requests; there is no automatic fallback.The general constructor requires an explicit registered backend.
VoronoiComplexGL(n,d)andVoronoiComplexSL(n,d)become convenience wrappers when a provider is selected, building quadratic records withfield.radicand := d. Their default Magma path, including explicitbackend := "magma", is unchanged.The patch loads the entry points during HAP initialization, adds a mock-provider GAP test, and documents the interface. The test checks arbitrary records, higher ranks, convenience wrappers, replacement of providers, and
failpropagation; it needs neither Julia nor Magma.A separate Julia Voronoi example (GL2, D=-7) CI job runs a small executable example against the HAP PR checkout, using a pinned ArithmeticVoronoi commit and Julia environment. It constructs a fresh complex for
GL(2,O)over the integers ofQ(sqrt(-7))through the record interface, then checks the cell-orbit counts[1,2,1]and integral homologyH1 = (Z/2)^3,H2 = Z/2 + Z/12. Dependency precompilation is a separate CI step using Julia's default parallelism, and the example reports package-loading time. The job log shows the request, enumeration progress and computed invariant factors. It needs no Magma, C++ exporter build or stored complexes. The ordinary GAP matrix keeps its existing dependencies.The external Julia adapter uses the same request records and JSON experiment runners as its enumerator and presentation pipeline. It validates its current quadratic, rank-two, maximal-order, free-lattice scope explicitly. It supplies stabilizers, orientation actions and equivariant boundaries; a contracting homotopy is not supplied. HAP gains no Julia runtime dependency.
Validation on GAP 4.16.1, Julia 1.13.2 and OSCAR 1.8.2:
git diff --checkpasses. The full upstream HAP suite has not been run locally; GitHub CI runs it.Opening as a draft for discussion of the provider API and its integration into HAP.