Repository navigation
fix: distrust affected eMudhra intermediate keys in TLS bindings - #121
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustls-webpki0.103.15 → 0.103.16 in the committed lockfile. Upstream release notes and implementation/regression tests confirm explicit distrust of the affected intermediate SPKIs (including cross-signs), rather than just changing root certificates.--lockedto the shared Cargo/Cross native-library build so the six platform builds feedinggetAlby/ldk-node-gouse the reviewed lockfile and fail rather than silently resolve a different graph.Scope and dependency audit
cargo tree --locked --features uniffi --target all -e normal,buildconfirms the shipped graph uses rustls 0.23.45 → rustls-webpki 0.103.16 for Electrum, Esplora/reqwest, and VSS. No production native-tls/OpenSSL or older rustls-webpki path was found, so no native-TLS switch or unrelated dependency upgrade is included.The lockfile still contains test-only rustls-webpki 0.101.7: test-binary downloaders (
minreqviaelectrsd/corepc-node) and the legacy ldk-node 0.6.2 VSS migration-test dependency. OpenSSL is confined to the optional LND integration-test dependency. These paths are not remediated by this update and are not included in shipped binding libraries. The registry currently has no newer 0.101 patch; 0.103.16 is not semver-compatible with 0.101.7. Upstream also released the mitigation as 0.104.0-alpha.8, which is not used here.This lockfile controls this repository's builds, not independent downstream Rust consumers' lockfiles. Existing published Go native binaries remain unchanged until rebuilt and published.
Verification
cargo +stable fmt --all -- --checkpassed (Rust 1.99.1; existing nightly-only rustfmt-option warnings).CARGO_BUILD_JOBS=2 CARGO_PROFILE_DEV_DEBUG=0 cargo +stable check --locked --features uniffipassed; existing generated UniFFI FeeRate deprecation warning only.v/0.103.16checkout,cargo +stable test --locked --lib --features ring distrusted_spkipassed, then the complete upstream library suite passed: 117 tests. The security implementation and all eight distrusted SPKI files were byte-compared with the registry crate used here. This is upstream verifier testing, not the node's integration suite.git diff --checkpassed; workflow YAML parsed successfully.The declared Rust 1.85 check fails because existing locked ICU/textwrap dependencies require Rust 1.88 (and idna_adapter requires 1.86); this PR does not change those packages. Full node integration tests, release linking, and the cross-platform artifact matrix have not been run locally.
Follow-up (not performed here)
After maintainer review/merge, the existing main-branch workflow must build and publish the updated native libraries to
getAlby/ldk-node-go. Verify all target artifacts and record the resulting Go repository commit/version; then update Hub to consume that version, rebuild, and test/release it. No merge, publish, or release is requested by this PR.