Repository navigation
fix: only create new check in IDs on "start" - #1252
Merged
Merged
Conversation
Collaborator
|
@whatyouhide hey hey thank you, could you rebase onto main? We had a small CI hiccup and it's addressed there, it will make CI run over here. |
whatyouhide
force-pushed
the
al/check-in-id
branch
from
October 22, 2026 10:02
b85b225 to
8c881d1
Compare
Collaborator
Author
|
@solnic done |
solnic
approved these changes
Oct 23, 2026
solnic
left a comment
solnic
left a comment
Collaborator
There was a problem hiding this comment.
Approved with a comment!
Oban and Quantum cron tests each defined the same expire_check_in_mapping!/1. Move it into Sentry.TestHelpers and call that from both suites. Co-Authored-By: Grok 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per the title!