Repository navigation
fix(test): skip unrelated envelopes in typed collectors - #1253
Merged
Merged
Conversation
collect_sentry_transactions/3 counted the first N envelopes, then dropped any that were not transactions. A log, metric, or client report ahead of the transaction made assert_sentry_transaction/2 report a timeout even when the transaction was sent. The same helper pattern applied to events, logs, check-ins, and metrics. Typed collectors now ignore envelopes that do not contain the requested item. Those envelopes do not consume expected_count. The traced-exception integration test no longer asks for two envelopes to look past the exception event. Co-Authored-By: Grok 4.7 <noreply@anthropic.com>
whatyouhide
marked this pull request as ready for review
October 23, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
masterCI failed inphoenix_appbecauseGET /transactionexpected one Sentry transaction within 1000ms and got none. This is a flaky test.collect_sentry_transactions/3(and the other typed collectors) read the first N envelopes and then kept only the requested item type. A log, metric, or client-report envelope in front of the transaction "consumed" that slot, so the assertion reported a timeout even when the transaction had been sent.With this PR, typed collectors now skip envelopes that do not contain the requested item. Those envelopes do not count toward
expected_count.