Repository navigation
test: bound subprocess waits and retry Breakpad cases - #2178
Merged
Merged
Conversation
Breakpad's known intermittent Windows deadlocks can leave child processes alive until CI hits its six-hour limit. Give test subprocesses a default 300-second timeout while preserving explicit overrides. Use the existing flaky plugin to run Breakpad cases up to three times, identifying them by test name or parameterized SENTRY_BACKEND options.
mujacica
approved these changes
Oct 8, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2945bcc. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2178 +/- ##
==========================================
+ Coverage 75.48% 75.49% +0.01%
==========================================
Files 103 103
Lines 28089 28089
Branches 5150 5150
==========================================
+ Hits 21203 21207 +4
+ Misses 5542 5534 -8
- Partials 1344 1348 +4 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breakpad's known intermittent Windows deadlocks can leave child processes alive until CI hits its six-hour limit.
Give test subprocesses a default 300-second timeout while preserving explicit overrides, and identify Breakpad tests and mark them as flaky to retry them up to 3 times.
See also: