Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"babel-jest": "^29.7.0",
"jest": "^29.7.0",
"react": "19.2.3",
"react-native": "0.87.1",
"react-native": "0.88.0",

Check warning on line 26 in dev-packages/e2e-tests/package.json

View check run for this annotation

@sentry/warden / warden: code-review

React versions in the workspace do not satisfy RN 0.88's peer dependency

`react-native@0.88.0` declares a `react: ^19.3.0` peer dependency, but this workspace and other packages using RN 0.88 still pin React below that range. Update React to a compatible version and keep `react-test-renderer` aligned where it is used; otherwise installs have an incompatible peer dependency and the RN/React pairing is unsupported.

Check warning on line 26 in dev-packages/e2e-tests/package.json

View check run for this annotation

@sentry/warden / warden: code-review

E2E matrix does not test React Native 0.88.0

The E2E workflow explicitly sets `RN_VERSION` from a matrix that still tops out at `0.87.1`, so its app builds use RN 0.87.1 instead of the newly pinned 0.88.0. Update the newer E2E matrix entry (or add a 0.88.0 entry) so this bump is exercised. The SwiftPM workflow is intentionally pinned to 0.87.1 as the first RN version with SwiftPM integration.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E matrix does not test React Native 0.88.0

The E2E workflow explicitly sets RN_VERSION from a matrix that still tops out at 0.87.1, so its app builds use RN 0.87.1 instead of the newly pinned 0.88.0. Update the newer E2E matrix entry (or add a 0.88.0 entry) so this bump is exercised. The SwiftPM workflow is intentionally pinned to 0.87.1 as the first RN version with SwiftPM integration.

Evidence
  • packages/core/package.json now pins react-native to 0.88.0.
  • .github/workflows/e2e-v2.yml sets RN_VERSION from matrix.rn-version, whose build matrix still lists 0.87.1 as its newest version; the test matrix also lists only 0.87.1.
  • dev-packages/e2e-tests/cli.mjs uses RN_VERSION to choose the app's RN version, so the workflow override prevents it from using the new package default.

Identified by Warden · code-review · XFC-WRG

"react-native-launch-arguments": "^4.0.2",
"typescript": "4.9.5",
"webdriverio": "^8.27.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@
"oxlint": "^1.56.0",
"oxlint-tsgolint": "^0.17.4",
"promise": "^8.3.0",
"react": "19.2.3",
"react-native": "0.87.1",
"react-native": "0.88.0",

Check warning on line 135 in packages/core/package.json

View check run for this annotation

@sentry/warden / warden: code-review

The RN 0.88 bump leaves the primary workspace on mismatched peer versions and tooling

The default sample now uses `react-native@0.88.0`, but keeps `react@19.2.3` even though RN 0.88 declares a `react@^19.3.0` peer. It also retains `@react-native/new-app-screen@0.87.1`, whose peer requires `react-native@0.87.1`, and its Babel/Metro tooling remains on 0.87.1. Align the companion versions in the RN 0.88 workspace; this finding is scoped to the default sample and core tooling, not the separately versioned macOS/visionOS setups.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React peer not updated

Medium Severity

RN 0.88.0 peers react@^19.3.0, but core and the main sample still pin react / react-test-renderer at 19.2.3. 0.88’s default web-based event dispatching depends on 19.3, so tests and the sample can hit peer failures or event-runtime mismatches. Flagged from the dependency-update review guidelines.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 19c380f. Configure here.

"react-test-renderer": "19.2.3",

Check warning on line 136 in packages/core/package.json

View check run for this annotation

@sentry/warden / warden: code-review

[AV5-H74] React versions in the workspace do not satisfy RN 0.88's peer dependency (additional location)

`react-native@0.88.0` declares a `react: ^19.3.0` peer dependency, but this workspace and other packages using RN 0.88 still pin React below that range. Update React to a compatible version and keep `react-test-renderer` aligned where it is used; otherwise installs have an incompatible peer dependency and the RN/React pairing is unsupported.
"rimraf": "^4.1.1",
"ts-jest": "^29.3.1",
Expand Down
2 changes: 1 addition & 1 deletion samples/expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
"expo-status-bar": "~57.0.0",
"expo-updates": "~57.0.4",
"expo-web-browser": "~57.0.0",
"react": "19.2.3",
"react-dom": "19.2.3",
"react-native": "0.86.2",
"react-native": "0.88.0",

Check warning on line 40 in samples/expo/package.json

View check run for this annotation

@sentry/warden / warden: code-review

[AV5-H74] React versions in the workspace do not satisfy RN 0.88's peer dependency (additional location)

`react-native@0.88.0` declares a `react: ^19.3.0` peer dependency, but this workspace and other packages using RN 0.88 still pin React below that range. Update React to a compatible version and keep `react-test-renderer` aligned where it is used; otherwise installs have an incompatible peer dependency and the RN/React pairing is unsupported.

Check warning on line 40 in samples/expo/package.json

View check run for this annotation

@sentry/warden / warden: code-review

Expo sample pairs RN 0.88 with React and Expo 57’s older toolchain

The Expo sample pins React 19.2.3 and Expo SDK 57 while this change raises React Native to 0.88.0. The lockfile declares RN 0.88’s React peer as ^19.3.0, and Expo 57’s Babel preset still resolves React Native codegen 0.86.3. Keep the sample on the Expo-supported React Native version, or upgrade its Expo and React dependencies together.

Check warning on line 40 in samples/expo/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

Expo SDK 57 sample uses an incompatible React Native version

Changing the sample to React Native 0.88.0 leaves it on Expo SDK 57 and React 19.2.3. The SDK 57 toolchain still resolves React Native 0.86.3 components, while React Native 0.88.0 declares React ^19.3.0 as a peer dependency. This unsupported combination can break Expo prebuild, native builds, or runtime behavior. Keep React Native on the version supported by SDK 57, or upgrade Expo and React together.

Check warning on line 40 in samples/expo/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

React Native 0.88 workspaces use React versions below its required peer

Several workspaces adopt `react-native@0.88.0` while pinning React below its declared `^19.3.0` peer requirement. Upgrade React to a satisfying version (and keep associated React packages aligned), or do not adopt RN 0.88.0 in those workspaces yet.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expo sample RN pin incompatible

High Severity

The Expo sample stays on SDK 57 (expo@^57.0.26) but react-native was bumped from 0.86.2 to 0.88.0. SDK 57 ships with RN 0.86; RN 0.88 belongs to SDK 58. Prebuild and Expo sample CI will fail or run an unsupported pairing. Flagged from the dependency-update review guidelines.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 19c380f. Configure here.

"react-native-gesture-handler": "~2.32.0",
"react-native-safe-area-context": "~5.7.0",
"react-native-screens": "~4.25.2",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native-macos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@sentry/react-native": "8.31.0",
"delay": "^6.0.0",
"react": "19.1.4",
"react-native": "0.81.6",
"react-native": "0.88.0",

Check failure on line 24 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

macOS sample pairs react-native 0.88.0 with react-native-macos 0.81.9

Bumping `react-native` to 0.88.0 while leaving `react-native-macos` at 0.81.9 and `@react-native/*` tooling at 0.81.6 breaks the out-of-tree macOS sample; keep those versions aligned or exclude this workspace from the RN updater.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS RN version mismatch

High Severity

react-native jumped to 0.88.0 while react-native-macos stays at 0.81.9 (and Babel/Metro configs at 0.81.6). Out-of-tree macOS builds require matching versions, so the macOS sample and its CI job will not build. Flagged from the dependency-update review guidelines.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 19c380f. Configure here.

"react-native-gesture-handler": "2.14.0",
"react-native-macos": "0.81.9",

Check warning on line 26 in samples/react-native-macos/package.json

View check run for this annotation

@sentry/warden / warden: code-review

The macOS sample pairs react-native 0.88.0 with a 0.81.9 macOS port

This upgrade changes the macOS sample's `react-native` to 0.88.0 while keeping `react-native-macos` at 0.81.9, whose declared peer dependency is exactly `react-native` 0.81.6. The sample's Podfile and Xcode build phases use `react-native-macos` for the native runtime, so the JS React Native version is outside the port's declared compatibility. Align the versions or exclude this sample from the bump.
"react-native-reanimated": "3.19.5",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native-tvos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dependencies": {
"@sentry/react-native": "8.31.0",
"react": "19.2.3",
"react-native": "npm:react-native-tvos@0.87.1-0"
"react-native": "0.88.0"

Check warning on line 18 in samples/react-native-tvos/package.json

View check run for this annotation

@sentry/warden / warden: code-review

tvOS sample no longer uses the tvOS React Native fork

This replaces the `react-native-tvos` npm alias with upstream `react-native`. The sample's tvOS Podfile and simulator build rely on the tvOS-specific fork; restore a compatible `react-native-tvos` alias so the tvOS sample can continue to build.

Check warning on line 18 in samples/react-native-tvos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

tvOS sample now resolves to upstream React Native instead of the tvOS fork

The tvOS sample’s dependency changed from the `react-native-tvos` alias to upstream `react-native@0.88.0`. The sample configures CocoaPods for tvOS and CI builds a tvOS simulator target, so it needs a React Native package with tvOS support; restore a compatible tvOS package alias.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tvOS sample lost RN fork

High Severity

The tvOS sample no longer aliases react-native to react-native-tvos and now pins stock 0.88.0. Stock React Native has no tvOS platform, so pod install and the tvOS CI build will fail. Flagged from the dependency-update review guidelines.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 19c380f. Configure here.

},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native-visionos/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@callstack/react-native-visionos": "0.79.6",
"@sentry/react-native": "8.31.0",
"react": "19.0.0",
"react-native": "0.79.6"
"react-native": "0.88.0"

Check failure on line 19 in samples/react-native-visionos/package.json

View check run for this annotation

@sentry/warden / warden: code-review

VisionOS build enables newer Hermes APIs against the 0.79.6 fork

Please keep `react-native` compatible with `@callstack/react-native-visionos` or update the fork and native toolchain together. The visionOS Podfile builds native code from the 0.79.6 fork but points Sentry's podspec at the sample's `react-native` package, now 0.88.0. That makes the podspec enable RN 0.81+ Hermes APIs when compiling against the fork's 0.79 headers, which the Podfile identifies as a compile failure.

Check warning on line 19 in samples/react-native-visionos/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

VisionOS sample enables newer Hermes APIs against its 0.79.6 fork

The visionOS Podfile builds native sources from `@callstack/react-native-visionos` 0.79.6 but directs `RNSentry.podspec` version detection to the sample's `react-native` package, now 0.88.0. Sentry therefore enables `NEW_HERMES_RUNTIME` for a build using the fork's 0.79 headers, which the Podfile identifies as incompatible and a compile failure. Keep `react-native` compatible with the fork or upgrade the fork and native toolchain together.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visionOS RN version mismatch

High Severity

react-native is now 0.88.0 while @callstack/react-native-visionos remains 0.79.6, with Babel/Metro still on 0.79.6. visionOS is an out-of-tree platform that must match the RN version, so the visionOS sample CI build will break. Flagged from the dependency-update review guidelines.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 19c380f. Configure here.

},
"devDependencies": {
"@babel/core": "^7.25.2",
Expand Down
2 changes: 1 addition & 1 deletion samples/react-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"@sentry/react-native": "8.31.0",
"@shopify/flash-list": "^2.0.2",
"delay": "^6.0.0",
"react": "19.2.3",
"react-native": "0.87.1",
"react-native": "0.88.0",

Check warning on line 57 in samples/react-native/package.json

View check run for this annotation

@sentry/warden / warden: code-review

[AV5-H74] React versions in the workspace do not satisfy RN 0.88's peer dependency (additional location)

`react-native@0.88.0` declares a `react: ^19.3.0` peer dependency, but this workspace and other packages using RN 0.88 still pin React below that range. Update React to a compatible version and keep `react-test-renderer` aligned where it is used; otherwise installs have an incompatible peer dependency and the RN/React pairing is unsupported.

Check warning on line 57 in samples/react-native/package.json

View check run for this annotation

@sentry/warden / warden: code-review

The sample uses an out-of-version Metro config with React Native 0.88

The sample upgrades `react-native` to 0.88.0 but keeps `@react-native/metro-config` at 0.87.1, and `metro.config.js` loads that package. The 0.88.0 React Native CLI plugin declares an exact `@react-native/metro-config` 0.88.0 peer, so the sample's Metro setup is out of sync with the version expected by its React Native runtime. Update the config package to 0.88.0 to avoid the peer mismatch and potential tooling incompatibility.

Check warning on line 57 in samples/react-native/package.json

View check run for this annotation

@sentry/warden / warden: code-review

Reanimated and Worklets declare incompatible RN peer ranges

The sample pins React Native 0.88.0 alongside `react-native-reanimated` 4.6.0 and `react-native-worklets` 0.12.1, whose declared React Native peer ranges stop at 0.87. Yarn can install this combination with an incompatible-peer warning, but it is outside the packages’ declared support and may cause native build or runtime incompatibilities. Use versions that declare RN 0.88 support, or verify compatibility before upgrading the sample.

Check warning on line 57 in samples/react-native/package.json

View check run for this annotation

@sentry/warden / warden: find-bugs

RN 0.88.0 breaks reanimated/worklets peer range 0.83-0.87

Bumping react-native to 0.88.0 leaves react-native-reanimated@4.6.0 and react-native-worklets@0.12.1 outside their declared peer range (0.83-0.87); upgrade those packages to RN 0.88-compatible releases.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RN companion packages not bumped

Medium Severity

Workspaces that intentionally moved to RN 0.88.0 still pin @react-native/babel-preset, jest-preset, metro-config, typescript-config, assets-registry, and new-app-screen at 0.87.1. RN 0.88’s CLI plugin peers metro-config@0.88.0, so Metro/Babel/Jest can fail or mis-transform. Flagged from the dependency-update review guidelines.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 19c380f. Configure here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worklets peer excludes RN 0.88

High Severity

The main sample now uses react-native@0.88.0 with react-native-worklets@0.12.1, whose peer range is react-native: 0.83 - 0.87. Reanimated 4 depends on that worklets package, so the sample (and its Android/iOS CI) can fail at install or runtime. Flagged from the dependency-update review guidelines.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 19c380f. Configure here.

"react-native-build-config": "^0.3.2",
"react-native-gesture-handler": "^3.0.1",
"react-native-image-picker": "^8.2.1",
Expand Down
Loading
Loading