Repository navigation
ref(cli): Move agent-conversation list onto the org-optional target positional - #1709
Merged
Merged
Conversation
…ositional agent-conversation list declared its target with LIST_TARGET_POSITIONAL and called resolveOrgOptionalFromArg in func. It now uses orgOptionalTarget and awaits target.resolved, like feedback list, replay list and explore. Resolution still goes through resolveOrgOptionalTarget with the same command name. Refs #1564 Co-Authored-By: BYK <burak.kaya@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
BYK
approved these changes
Oct 29, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1564. Now that #1575 has merged,
agent-conversation listcan move to the target positional.Before this change,
agent-conversation listdeclared its target withLIST_TARGET_POSITIONALand calledresolveOrgOptionalFromArginsidefunc. Now it usesorgOptionalTargetand awaitstarget.resolved, the same wayfeedback list,replay listandexploredo. Resolution hasn't changed. It still goes throughresolveOrgOptionalTargetwith the command nameagent-conversation list. Completion is also the same, since both parsers carry the org/project tag.One behavior change: a malformed target now fails in Stricli's argument scanner and exits 252, like every other target positional since #1655. Before, it failed inside
func.What's left on
LIST_TARGET_POSITIONAL/NAMED_LIST_TARGET_POSITIONAL(issue list,dsn list,alert issues list,project list) goes throughdispatchOrgScopedList, which resolves differently for each target mode. None of them has a single resolver to bind, so I've left them out of this PR. The follow-up is tracked on #1564.via BYK.
--
View Junior Session in Sentry