Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each scriptlet
funcinlined its ownsafeSelf(), so stacked hooks compounded (2^n). #63 shared the cache through aSymbol.forproperty onglobalThis, which pages can enumerate and use to reach the unhooked natives.uBO avoids this by running all scriptlets of a frame in one scope with each dependency declared once. This gives the extension what it needs for that, and drops the per-scriptlet
funcwrappers together with the global:functions: every function once; each scriptlet getsfnanddependenciescompose(calls, scriptletGlobals): one code string per injection, for registered scripts andchrome.userScripts.executerun(scriptletGlobals, calls): one self-contained function forchrome.scripting.executeScriptBundle goes from 2.2 MB to 0.5 MB.