Skip to content

doc: describe what RoCE mode configures and its limits - #358

Open
pau-hedgehog wants to merge 1 commit into
masterfrom
pau/roce-mode-fixed-config
Open

pau-hedgehog wants to merge 1 commit into
masterfrom
pau/roce-mode-fixed-config

Conversation

@pau-hedgehog

@pau-hedgehog pau-hedgehog commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Adds a "What RoCE mode configures" section to the switch user guide.

  • roce: true applies buffer sizing, PFC, ECN and queue scheduling as one unit
  • The Fabric API has no fields to adjust individual PFC, ECN, buffer or scheduler parameters
  • The agent manages only whether RoCE mode is on; manual parameter changes are unsupported and are lost when RoCE is toggled
  • RoCE mode is per switch; enable it on every switch on the traffic path

@pau-hedgehog
pau-hedgehog requested a review from a team as a code owner October 7, 2026 21:26
@pau-hedgehog
pau-hedgehog requested a review from Frostman October 7, 2026 21:26
@pau-hedgehog pau-hedgehog self-assigned this Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

🚀 Deployed on https://preview-358--hedgehog-docs.netlify.app

@pau-hedgehog
pau-hedgehog requested review from mrbojangles3 and a lite review from Copilot October 7, 2026 21:33
@pau-hedgehog
pau-hedgehog force-pushed the pau/roce-mode-fixed-config branch from e54ca6d to c522867 Compare October 7, 2026 21:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Remaining comments are minor documentation wording and clarity nits.

0 open findings

What changed in this PR

Documents what roce: true configures and its operational limitations.

Changes:

  • Describes buffer, PFC, ECN, and queue scheduling settings.
  • Documents API limitations and CLI reconciliation.
  • Explains per-switch RoCE enablement and DSCP guidance.
File Description
docs/​user-guide/​devices.md Adds the “What RoCE mode configures” section.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pau-hedgehog
pau-hedgehog force-pushed the pau/roce-mode-fixed-config branch from c522867 to 79ba8af Compare October 7, 2026 21:49
@pau-hedgehog
pau-hedgehog marked this pull request as draft October 7, 2026 21:53
@pau-hedgehog
pau-hedgehog force-pushed the pau/roce-mode-fixed-config branch from 79ba8af to 23e80ed Compare October 8, 2026 05:58
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
@pau-hedgehog
pau-hedgehog force-pushed the pau/roce-mode-fixed-config branch from 23e80ed to 51e86e7 Compare October 8, 2026 06:07
@pau-hedgehog
pau-hedgehog marked this pull request as ready for review October 8, 2026 06:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants