Repository navigation
ci(renovate): run validator on every pull request - #4
Merged
Merged
Conversation
Remove the pull_request path filter so the check is always reported. A path-filtered check that is required in branch protection would leave unrelated PRs (for example docs-only) stuck waiting for a status that never runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
To make the validator a required status check on
main(task 1.2 of the change), it must run on every pull request. The currentpull_requesttrigger is path-filtered to*.jsonand the workflow file, so a required check would leave PRs that touch neither (e.g. a README-only change) permanently "waiting for status to be reported" and unable to merge.Change
pull_requestpath filter — the validator now runs on every PR.pushpath filter (no need to run on everymainpush).Auto-detection means unrelated PRs simply validate whatever config/preset files are present.
Ordering
Merge this, then enable branch protection with
Validate Renovate configas a required check onmain. Draft pending review.