Repository navigation
Conversation
…Text.Json Exposes quicktype-core's C# framework renderer option in the VS Code extension. Default SystemTextJson so generated code needs no NuGet package; NewtonSoft remains available. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
quicktype.csharp.framework:SystemTextJson(default) |NewtonSoft. Passed through to quicktype-core's existing C#frameworkrenderer option.Why
The extension hardcodes core's default, so every C# paste emits Newtonsoft.Json and requires a NuGet package. System.Text.Json is built into .NET Core 3+/.NET 5+, so the generated code works with zero dependencies. This was requested in quicktype-vscode#44 (now archived) and is related to #2958.
Note on default
Default is
SystemTextJson, which changes output for existing C# users of the extension. Happy to flip it toNewtonSoftfor backwards compatibility if preferred; one-line change inpackage.json.Testing
tscforpackages/quicktype-vscodepasses, Biome clean.@vscode/test-electron: pasted JSON into a C# document with each framework value and with the setting unset, assertedusing System.Text.Json/using Newtonsoft.Jsonaccordingly.🤖 Generated with Claude Code