Repository navigation
Fix computation of micro-scale of S scales. - #1051
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_995216262
branch
from
October 8, 2026 08:41
ed7109f to
4df4f22
Compare
Before it would reduce seperatly v microsales and S scales, Then multiply two togheter and update max based on that. Now we explicity compute V-microscales * S, this way values are more accurate, it cost extra multply but previous code had relatively inefficient two reduce max, ops, it is probably perf win anyways. PiperOrigin-RevId: 995681058
copybara-service
Bot
force-pushed
the
test_995216262
branch
from
October 8, 2026 09:12
4df4f22 to
f0e67a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix computation of micro-scale of S scales.
Before it would reduce seperatly v microsales and S scales,
Then multiply two togheter and update max based on that.
Now we explicity compute V-microscales * S, this way values are more accurate, it cost extra multply but previous code had relatively inefficient two reduce max, ops, it is probably perf win anyways.