feat: Add actions policies endpoints - #4604
Open
Bobrovskii wants to merge 2 commits into
Open
Bobrovskii wants to merge 2 commits into
Bobrovskii wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4604 +/- ##
==========================================
+ Coverage 98.60% 98.61% +0.01%
==========================================
Files 198 199 +1
Lines 18538 18647 +109
==========================================
+ Hits 18279 18389 +110
+ Misses 259 258 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@Bobrovskii - please fix the linter errors by running |
Contributor
Author
|
Fixed the linter issues and the missing test coverage. Thanks |
gmlewis
approved these changes
Oct 3, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @Bobrovskii!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
| return policies, resp, nil | ||
| } | ||
|
|
||
| func (s *ActionsService) createPolicy(ctx context.Context, u string, body ActionsPolicy) (*ActionsPolicy, *Response, error) { |
Contributor
There was a problem hiding this comment.
ActionsPolicy contains some extra fields that aren't needed when creating a policy. Can we introduce a new request struct for this?
| return policy, resp, nil | ||
| } | ||
|
|
||
| func (s *ActionsService) updatePolicy(ctx context.Context, u string, body ActionsPolicy) (*ActionsPolicy, *Response, error) { |
Contributor
There was a problem hiding this comment.
Same here, some extra fields that aren't needed when updating a policy.
Comment on lines
+46
to
+59
| type ActionsPolicy struct { | ||
| ID *int64 `json:"id,omitempty"` | ||
| Name *string `json:"name,omitempty"` | ||
| Target *ActionsPolicyTarget `json:"target,omitempty"` | ||
| SourceType *RulesetSourceType `json:"source_type,omitempty"` | ||
| Source *string `json:"source,omitempty"` | ||
| Enforcement *RulesetEnforcement `json:"enforcement,omitempty"` | ||
| Conditions *ActionsPolicyConditions `json:"conditions,omitempty"` | ||
| Rules []*ActionsPolicyRule `json:"rules,omitzero"` | ||
| NodeID *string `json:"node_id,omitempty"` | ||
| Links *RepositoryRulesetLinks `json:"_links,omitempty"` | ||
| CreatedAt *Timestamp `json:"created_at,omitempty"` | ||
| UpdatedAt *Timestamp `json:"updated_at,omitempty"` | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| type ActionsPolicy struct { | |
| ID *int64 `json:"id,omitempty"` | |
| Name *string `json:"name,omitempty"` | |
| Target *ActionsPolicyTarget `json:"target,omitempty"` | |
| SourceType *RulesetSourceType `json:"source_type,omitempty"` | |
| Source *string `json:"source,omitempty"` | |
| Enforcement *RulesetEnforcement `json:"enforcement,omitempty"` | |
| Conditions *ActionsPolicyConditions `json:"conditions,omitempty"` | |
| Rules []*ActionsPolicyRule `json:"rules,omitzero"` | |
| NodeID *string `json:"node_id,omitempty"` | |
| Links *RepositoryRulesetLinks `json:"_links,omitempty"` | |
| CreatedAt *Timestamp `json:"created_at,omitempty"` | |
| UpdatedAt *Timestamp `json:"updated_at,omitempty"` | |
| } | |
| type ActionsPolicy struct { | |
| ID int64 `json:"id"` | |
| Name string `json:"name"` | |
| Target ActionsPolicyTarget `json:"target"` | |
| SourceType RulesetSourceType `json:"source_type"` | |
| Source string `json:"source"` | |
| Enforcement RulesetEnforcement `json:"enforcement"` | |
| Conditions *ActionsPolicyConditions `json:"conditions,omitempty"` | |
| Rules []*ActionsPolicyRule `json:"rules,omitzero"` | |
| NodeID *string `json:"node_id,omitempty"` | |
| Links *RepositoryRulesetLinks `json:"_links,omitempty"` | |
| CreatedAt *Timestamp `json:"created_at,omitempty"` | |
| UpdatedAt *Timestamp `json:"updated_at,omitempty"` | |
| } |
We don't use omitempty with required fields.
"required": [
"id",
"name",
"target",
"source_type",
"source",
"enforcement"
],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add actions policies endpoints
Fixes: #4583