Repository navigation
fix(petpassport): stop opening a walk from marking it walked - #68
Open
harish-gaggar wants to merge 2 commits into
Open
harish-gaggar wants to merge 2 commits into
harish-gaggar wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Viewing a saved itinerary also flipped its walked flag and left the details badge stale. Opening a passport and changing walked status are now separate actions, and a failed save rolls the badge back.
…ight A second click before the first save finished could store a different walked value than the badge showed. Extra clicks now wait until that save settles.
harish-gaggar
force-pushed
the
fix/pet-passport-walk-status
branch
from
October 11, 2026 17:06
dbd16ef to
9bd02b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening a saved Pet Passport walk also toggled its walked flag. The details view then kept the previous badge, so reading an itinerary marked the walk as done.
The card title now only opens the itinerary. A separate Walked / Not walked button on the card and in the details view saves the status. A second click while a save is in flight is ignored, and a failed save rolls the badge back. Itinerary text wraps on word boundaries, and the details header no longer collides with the back button.
Motivation and Context
The demo's saved-walk list is how a user reviews a route the agent already created. Coupling "open" and "mark walked" made that review change stored state, and the details badge did not match the list.
How Has This Been Tested?
/api/pathsand exercised it in the browser.file:///tmp/path was rewritten for the page.walked: true.app.jsparses cleanly.Breaking Changes
None. The walked flag still posts the full path object to
/api/paths.Types of changes
Checklist