Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VerifyCalculateNeeded() is meant to prove CalculateNeeded() agrees with char_table, but its loop runs
for (int i = 0; i < 1; i++)so only tag 0 is ever checked. The other 255 entries go unverified, which leaves the static_assert inert for every tag except the first. CalculateNeeded() is what RefillTag() uses asneeded, andneededbounds the memcpy that stitches tag bytes into the fixed-size scratch_[kMaximumTagLength] buffer, so this is the check that keeps the two representations from drifting apart.Iterate the whole table (i < 256). The check stays at compile time and the current table passes cleanly; verified by building with -DCMAKE_CXX_STANDARD=17 (so the C++14-gated static_assert is actually evaluated) with the full test suite green. Confirmed the guard was inert by corrupting one char_table entry: the build still passed under the old bound and fails under the new one.